Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/poll: avoid memory leak in Writev #32138

Closed
wants to merge 1 commit into from

Conversation

@taoyuanyuan
Copy link
Contributor

taoyuanyuan commented May 19, 2019

The chunks that were referenced by fd.iovecs would not be GC.

@googlebot googlebot added the cla: yes label May 19, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 19, 2019

This PR (HEAD: cee7d59) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/178037 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 19, 2019

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/178037.
After addressing review feedback, remember to publish your drafts!

@taoyuanyuan taoyuanyuan force-pushed the taoyuanyuan:fix-writev-mem-leak branch from cee7d59 to 3972193 May 19, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 19, 2019

This PR (HEAD: 3972193) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/178037 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 19, 2019

Message from Brad Fitzpatrick:

Patch Set 2:

(1 comment)

R=iant


Please don’t reply on this GitHub thread. Visit golang.org/cl/178037.
After addressing review feedback, remember to publish your drafts!

@taoyuanyuan taoyuanyuan force-pushed the taoyuanyuan:fix-writev-mem-leak branch from 3972193 to e0b7f68 May 19, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 19, 2019

This PR (HEAD: e0b7f68) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/178037 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 19, 2019

Message from Yang Tian:

Patch Set 3:

Patch Set 2:

(1 comment)

R=iant

Uploaded patch


Please don’t reply on this GitHub thread. Visit golang.org/cl/178037.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 20, 2019

Message from Ian Lance Taylor:

Patch Set 3: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/178037.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 20, 2019

Message from Gobot Gobot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=025d40ed


Please don’t reply on this GitHub thread. Visit golang.org/cl/178037.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 20, 2019

Message from Gobot Gobot:

Patch Set 3: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/178037.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 20, 2019

Message from Ian Lance Taylor:

Patch Set 3: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/178037.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request May 20, 2019
The chunks that were referenced by fd.iovecs would not be GC.

Change-Id: I7bfcb91a3fef57a4a1861168e9cd3ab55ce1334e
GitHub-Last-Rev: e0b7f68
GitHub-Pull-Request: #32138
Reviewed-on: https://go-review.googlesource.com/c/go/+/178037
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 20, 2019

This PR is being closed because golang.org/cl/178037 has been merged.

@gopherbot gopherbot closed this May 20, 2019
@taoyuanyuan taoyuanyuan deleted the taoyuanyuan:fix-writev-mem-leak branch May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.