-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/poll: avoid memory leak in Writev #32138
Conversation
This PR (HEAD: cee7d59) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/178037 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/178037. |
cee7d59
to
3972193
Compare
This PR (HEAD: 3972193) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/178037 to see it. Tip: You can toggle comments from me using the |
Message from Brad Fitzpatrick: Patch Set 2: (1 comment) R=iant Please don’t reply on this GitHub thread. Visit golang.org/cl/178037. |
3972193
to
e0b7f68
Compare
This PR (HEAD: e0b7f68) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/178037 to see it. Tip: You can toggle comments from me using the |
Message from Yang Tian: Patch Set 3:
Uploaded patch Please don’t reply on this GitHub thread. Visit golang.org/cl/178037. |
Message from Ian Lance Taylor: Patch Set 3: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/178037. |
Message from Gobot Gobot: Patch Set 3: TryBots beginning. Status page: https://farmer.golang.org/try?commit=025d40ed Please don’t reply on this GitHub thread. Visit golang.org/cl/178037. |
Message from Gobot Gobot: Patch Set 3: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/178037. |
Message from Ian Lance Taylor: Patch Set 3: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/178037. |
The chunks that were referenced by fd.iovecs would not be GC. Change-Id: I7bfcb91a3fef57a4a1861168e9cd3ab55ce1334e GitHub-Last-Rev: e0b7f68 GitHub-Pull-Request: #32138 Reviewed-on: https://go-review.googlesource.com/c/go/+/178037 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
This PR is being closed because golang.org/cl/178037 has been merged. |
The chunks that were referenced by fd.iovecs would not be GC.