Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: make env -w and -u validate GOOS and GOARCH values #34221

Closed
wants to merge 6 commits into from

Conversation

@jsign
Copy link
Contributor

jsign commented Sep 10, 2019

This change makes go env -w and -u check invalid GOOS and GOARCH values and abort if that's the case.

Fixes #34194

@googlebot googlebot added the cla: yes label Sep 10, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Sep 10, 2019

This PR (HEAD: c899a27) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Sep 10, 2019

Message from Akhil Indurti:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Sep 10, 2019

This PR (HEAD: 345f989) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Sep 10, 2019

Message from Ignacio Hagopian:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Sep 10, 2019

Message from Brad Fitzpatrick:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@jsign jsign changed the title cmd/go: env -w and -u check for invalid GOOS and GOARCH values cmd/go: make env -w and -u validate GOOS and GOARCH values Sep 10, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Sep 10, 2019

Message from Ignacio Hagopian:

Patch Set 3:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Sep 13, 2019

Message from Bryan C. Mills:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Sep 13, 2019

Message from Ignacio Hagopian:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@jsign jsign force-pushed the jsign:issue34194 branch from 345f989 to e48d2cd Sep 28, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Sep 28, 2019

This PR (HEAD: e48d2cd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Sep 28, 2019

Message from Ignacio Hagopian:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the golang:master branch 2 times, most recently from a1b0af9 to 93a79bb Oct 1, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 2, 2019

Message from Bryan C. Mills:

Patch Set 4: Run-TryBot+1 Code-Review+1

Code looks good. Please add a regression test in cmd/go/testdata/script.


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 2, 2019

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1b25946e


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 2, 2019

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the golang:master branch 2 times, most recently from 07b4abd to 19a7490 Oct 3, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 12, 2019

This PR (HEAD: 300613e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@jsign jsign force-pushed the jsign:issue34194 branch from 300613e to 6fab113 Oct 12, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 12, 2019

This PR (HEAD: 6fab113) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 12, 2019

Message from Ignacio Hagopian:

Patch Set 6:

Patch Set 4: Run-TryBot+1 Code-Review+1

Code looks good. Please add a regression test in cmd/go/testdata/script.

Added tests in existing env_write.txt and rebased to master.


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 12, 2019

This PR (HEAD: 8461841) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 13, 2019

Message from Agniva De Sarker:

Patch Set 7: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 13, 2019

Message from Gobot Gobot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e83c5b59


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 13, 2019

Message from Gobot Gobot:

Patch Set 7: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 15, 2019

Message from Bryan C. Mills:

Patch Set 7: Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 15, 2019

Message from Ignacio Hagopian:

Patch Set 7:

Patch Set 7:

Sorry, looks like there is also a merge conflict with CL 200867 that will need to be resolved. 😞

Don't worry, I'll take a look soon while rebasing again and also adding your test suggestion.


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@jsign jsign force-pushed the jsign:issue34194 branch from 8461841 to 3fb590a Oct 17, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 17, 2019

This PR (HEAD: 3fb590a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot gopherbot force-pushed the golang:master branch from 03fb1f6 to a813d3c Oct 22, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 29, 2019

Message from Ignacio Hagopian:

Patch Set 8:

Patch Set 7:

Sorry, looks like there is also a merge conflict with CL 200867 that will need to be resolved. 😞

This was resolved in Patch Set 7.
Seems now we have another conflict again... not sure how bad it is, but maybe I'll take a look and fix it if we can merge it fast afterwards since this is kind of a pain.


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the golang:master branch 10 times, most recently from 4a7ed1f to 0f992b9 Nov 5, 2019
@jsign jsign force-pushed the jsign:issue34194 branch from 3fb590a to ee67f09 Nov 9, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 9, 2019

This PR (HEAD: ee67f09) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 9, 2019

Message from Ignacio Hagopian:

Patch Set 9:

Patch Set 8:

Patch Set 7:

Sorry, looks like there is also a merge conflict with CL 200867 that will need to be resolved. 😞

This was resolved in Patch Set 7.
Seems now we have another conflict again... not sure how bad it is, but maybe I'll take a look and fix it if we can merge it fast afterwards since this is kind of a pain.

Rebased and solved conflicts!


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 10, 2019

Message from Bryan C. Mills:

Patch Set 9: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 10, 2019

Message from Gobot Gobot:

Patch Set 9:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=addb528b


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 10, 2019

Message from Gobot Gobot:

Patch Set 9: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 10, 2019
This change makes go env -w and -u check invalid GOOS and GOARCH values and abort if that's the case.

Fixes #34194

Change-Id: Idca8e93bb0b190fd273bf786c925be7993c24a2b
GitHub-Last-Rev: ee67f09
GitHub-Pull-Request: #34221
Reviewed-on: https://go-review.googlesource.com/c/go/+/194617
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 10, 2019

This PR is being closed because golang.org/cl/194617 has been merged.

@gopherbot gopherbot closed this Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.