cmd/go: make env -w and -u validate GOOS and GOARCH values #34221

jsign · 2019-09-10T20:57:57Z

This change makes go env -w and -u check invalid GOOS and GOARCH values and abort if that's the case.

gopherbot · 2019-09-10T21:05:04Z

This PR (HEAD: c899a27) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-09-10T21:20:24Z

Message from Akhil Indurti:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-10T21:33:41Z

This PR (HEAD: 345f989) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-09-10T21:37:00Z

Message from Ignacio Hagopian:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-10T22:04:33Z

Message from Brad Fitzpatrick:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-10T22:11:01Z

Message from Ignacio Hagopian:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-13T14:56:26Z

Message from Bryan C. Mills:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-13T20:57:21Z

Message from Ignacio Hagopian:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-28T18:45:14Z

This PR (HEAD: e48d2cd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-09-28T18:50:39Z

Message from Ignacio Hagopian:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-02T14:47:08Z

Message from Bryan C. Mills:

Patch Set 4: Run-TryBot+1 Code-Review+1

Code looks good. Please add a regression test in cmd/go/testdata/script.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-02T14:47:09Z

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1b25946e

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-02T14:57:56Z

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-12T20:48:23Z

This PR (HEAD: 300613e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-12T21:00:01Z

This PR (HEAD: 6fab113) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-12T21:03:06Z

Message from Ignacio Hagopian:

Patch Set 6:

Patch Set 4: Run-TryBot+1 Code-Review+1

Code looks good. Please add a regression test in cmd/go/testdata/script.

Added tests in existing env_write.txt and rebased to master.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-12T21:13:42Z

This PR (HEAD: 8461841) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-13T03:18:33Z

Message from Agniva De Sarker:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-13T03:18:34Z

Message from Gobot Gobot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e83c5b59

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-13T03:27:54Z

Message from Gobot Gobot:

Patch Set 7: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-15T12:22:46Z

Message from Bryan C. Mills:

Patch Set 7: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-15T18:19:02Z

Message from Ignacio Hagopian:

Patch Set 7:

Patch Set 7:

Sorry, looks like there is also a merge conflict with CL 200867 that will need to be resolved. 😞

Don't worry, I'll take a look soon while rebasing again and also adding your test suggestion.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-17T00:21:57Z

This PR (HEAD: 3fb590a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-29T21:41:39Z

Message from Ignacio Hagopian:

Patch Set 8:

Patch Set 7:

Sorry, looks like there is also a merge conflict with CL 200867 that will need to be resolved. 😞

This was resolved in Patch Set 7.
Seems now we have another conflict again... not sure how bad it is, but maybe I'll take a look and fix it if we can merge it fast afterwards since this is kind of a pain.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!


        cmd/go: env -w and -u check for invalid GOOS and GOARCH values


        gofmt


        make -u aware of explicit env vars


        regression tests


        change tests to not use nacl/amd64p32


        extra test case for incompatible combination

gopherbot · 2019-11-09T14:41:16Z

This PR (HEAD: ee67f09) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194617 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-11-09T14:45:28Z

Message from Ignacio Hagopian:

Patch Set 9:

Patch Set 8:

Patch Set 7:

Sorry, looks like there is also a merge conflict with CL 200867 that will need to be resolved. 😞

This was resolved in Patch Set 7.
Seems now we have another conflict again... not sure how bad it is, but maybe I'll take a look and fix it if we can merge it fast afterwards since this is kind of a pain.

Rebased and solved conflicts!

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-11-10T13:32:16Z

Message from Bryan C. Mills:

Patch Set 9: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-11-10T13:32:17Z

Message from Gobot Gobot:

Patch Set 9:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=addb528b

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-11-10T13:41:55Z

Message from Gobot Gobot:

Patch Set 9: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194617.
After addressing review feedback, remember to publish your drafts!


        cmd/go: make env -w and -u validate GOOS and GOARCH values

This change makes go env -w and -u check invalid GOOS and GOARCH values and abort if that's the case. Fixes #34194 Change-Id: Idca8e93bb0b190fd273bf786c925be7993c24a2b GitHub-Last-Rev: ee67f09 GitHub-Pull-Request: #34221 Reviewed-on: https://go-review.googlesource.com/c/go/+/194617 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>

gopherbot · 2019-11-10T13:43:04Z

This PR is being closed because golang.org/cl/194617 has been merged.

googlebot added the cla: yes label Sep 10, 2019

Mizommz approved these changes Sep 10, 2019

View changes

jsign changed the title ~~cmd/go: env -w and -u check for invalid GOOS and GOARCH values~~ cmd/go: make env -w and -u validate GOOS and GOARCH values Sep 10, 2019

jsign force-pushed the jsign:issue34194 branch from 345f989 to e48d2cd Sep 28, 2019

gopherbot force-pushed the golang:master branch 2 times, most recently from a1b0af9 to 93a79bb Oct 1, 2019

gopherbot force-pushed the golang:master branch 2 times, most recently from 07b4abd to 19a7490 Oct 3, 2019

jsign force-pushed the jsign:issue34194 branch from 300613e to 6fab113 Oct 12, 2019

jsign force-pushed the jsign:issue34194 branch from 8461841 to 3fb590a Oct 17, 2019

gopherbot force-pushed the golang:master branch from 03fb1f6 to a813d3c Oct 22, 2019

gopherbot force-pushed the golang:master branch 10 times, most recently from 4a7ed1f to 0f992b9 Nov 5, 2019

jsign added 6 commits Sep 10, 2019

cmd/go: env -w and -u check for invalid GOOS and GOARCH values

Loading status checks…

dc24a9c

gofmt

Loading status checks…

5982ed8

make -u aware of explicit env vars

Loading status checks…

3176db2

regression tests

Loading status checks…

0d37cb1

change tests to not use nacl/amd64p32

Loading status checks…

66fa86c

extra test case for incompatible combination

Loading status checks…

ee67f09

jsign force-pushed the jsign:issue34194 branch from 3fb590a to ee67f09 Nov 9, 2019

gopherbot closed this Nov 10, 2019

golang/go

Join GitHub today

cmd/go: make env -w and -u validate GOOS and GOARCH values #34221

cmd/go: make env -w and -u validate GOOS and GOARCH values #34221

Conversation

jsign commented Sep 10, 2019

This comment has been minimized.

gopherbot commented Sep 10, 2019

This comment has been minimized.

gopherbot commented Sep 10, 2019

This comment has been minimized.

gopherbot commented Sep 10, 2019

This comment has been minimized.

gopherbot commented Sep 10, 2019

This comment has been minimized.

gopherbot commented Sep 10, 2019

This comment has been minimized.

gopherbot commented Sep 10, 2019

This comment has been minimized.

gopherbot commented Sep 13, 2019

This comment has been minimized.

gopherbot commented Sep 13, 2019

This comment has been minimized.

gopherbot commented Sep 28, 2019

This comment has been minimized.

gopherbot commented Sep 28, 2019

This comment has been minimized.

gopherbot commented Oct 2, 2019

This comment has been minimized.

gopherbot commented Oct 2, 2019

This comment has been minimized.

gopherbot commented Oct 2, 2019

This comment has been minimized.

gopherbot commented Oct 12, 2019

This comment has been minimized.

gopherbot commented Oct 12, 2019

This comment has been minimized.

gopherbot commented Oct 12, 2019

This comment has been minimized.

gopherbot commented Oct 12, 2019

This comment has been minimized.

gopherbot commented Oct 13, 2019

This comment has been minimized.

gopherbot commented Oct 13, 2019

This comment has been minimized.

gopherbot commented Oct 13, 2019

This comment has been minimized.

gopherbot commented Oct 15, 2019

This comment has been minimized.

gopherbot commented Oct 15, 2019

This comment has been minimized.

gopherbot commented Oct 17, 2019

This comment has been minimized.

gopherbot commented Oct 29, 2019

This comment has been minimized.

gopherbot commented Nov 9, 2019

This comment has been minimized.

gopherbot commented Nov 9, 2019

This comment has been minimized.

gopherbot commented Nov 10, 2019

This comment has been minimized.

gopherbot commented Nov 10, 2019

This comment has been minimized.

gopherbot commented Nov 10, 2019

This comment has been minimized.

gopherbot commented Nov 10, 2019