Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upcrypto/x509: fix CreateCRL for Ed25519 CAs #35241
Conversation
This makes Ed25519 certificates work for CreateCRL(). This previously failed (panic: crypto: requested hash function #0 is unavailable) because the hash could not be skipped, but Ed25519 uses no hash. A similar fix has been applied in a few other places when Ed25519 was added when Ed25519 certificates were originally introduced, but was missed here. Change-Id: I16fcfcd53ba3bb8f773e5de972b8fedde1f6350e
This comment has been minimized.
This comment has been minimized.
gopherbot
commented
Oct 30, 2019
This PR (HEAD: bf7f145) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/204046 to see it. Tip: You can toggle comments from me using the |
This comment has been minimized.
This comment has been minimized.
gopherbot
commented
Oct 30, 2019
Message from Lorenz Brun: Patch Set 1: BTW this has been submitted on GitHub because Gerrit really doesn't like me adding private keys for the tests (![remote rejected] HEAD -> refs/for/master (found a private key)). There does not seem to be a documented workaround and the given command line argument (-o nokeycheck) does not work for submissions. So I've just used GitHub which doesn't have the same restrictions. It's a cool feature but the override should really work. Please don’t reply on this GitHub thread. Visit golang.org/cl/204046. |
This comment has been minimized.
This comment has been minimized.
gopherbot
commented
Oct 30, 2019
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/204046. |
This comment has been minimized.
This comment has been minimized.
gopherbot
commented
Oct 30, 2019
Message from Lorenz Brun: Patch Set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/204046. |
This comment has been minimized.
This comment has been minimized.
gopherbot
commented
Oct 30, 2019
Message from Brad Fitzpatrick: Patch Set 3: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/204046. |
This comment has been minimized.
This comment has been minimized.
gopherbot
commented
Oct 30, 2019
Message from Gobot Gobot: Patch Set 3: TryBots beginning. Status page: https://farmer.golang.org/try?commit=532980eb Please don’t reply on this GitHub thread. Visit golang.org/cl/204046. |
This comment has been minimized.
This comment has been minimized.
gopherbot
commented
Oct 30, 2019
Message from Gobot Gobot: Patch Set 3: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/204046. |
This comment has been minimized.
This comment has been minimized.
gopherbot
commented
Nov 10, 2019
Message from Lorenz Brun: Patch Set 3: A friendly ping Please don’t reply on this GitHub thread. Visit golang.org/cl/204046. |
This makes Ed25519 certificates work for CreateCRL(). This previously failed (panic: crypto: requested hash function #0 is unavailable) because the hash could not be skipped, but Ed25519 uses no hash. A similar fix has been applied in a few other places when Ed25519 was added when Ed25519 certificates were originally introduced, but was missed here. Change-Id: I16fcfcd53ba3bb8f773e5de972b8fedde1f6350e Change-Id: I16fcfcd53ba3bb8f773e5de972b8fedde1f6350e GitHub-Last-Rev: bf7f145 GitHub-Pull-Request: #35241 Reviewed-on: https://go-review.googlesource.com/c/go/+/204046 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org>
This comment has been minimized.
This comment has been minimized.
gopherbot
commented
Nov 11, 2019
Message from Filippo Valsorda: Patch Set 3: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/204046. |
This comment has been minimized.
This comment has been minimized.
gopherbot
commented
Nov 11, 2019
Message from Filippo Valsorda: Patch Set 3: Thank you, good catch. Please don’t reply on this GitHub thread. Visit golang.org/cl/204046. |
This comment has been minimized.
This comment has been minimized.
gopherbot
commented
Nov 11, 2019
This PR is being closed because golang.org/cl/204046 has been merged. |
lorenz commentedOct 30, 2019
This makes Ed25519 certificates work for CreateCRL(). This previously
failed (panic: crypto: requested hash function #0 is unavailable) because
the hash could not be skipped, but Ed25519 uses no hash.
A similar fix has been applied in a few other places when Ed25519 was added
when Ed25519 certificates were originally introduced, but was missed
here.
Change-Id: I16fcfcd53ba3bb8f773e5de972b8fedde1f6350e