runtime: allow float syscall return values on windows amd64

[richardwilkes]

RELNOTE=yes
Fixes #37273

[gopherbot]

This PR (HEAD: efd63af) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/220578 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/220578.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Jason A. Donenfeld:

Patch Set 1:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/220578.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Richard Wilkes:

Patch Set 1:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/220578.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Alex Brainman:

Patch Set 1: Run-TryBot+1

(1 comment)

Thank you very much for working on this.

Alex

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/220578.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=0cc2ff87

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/220578.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/220578.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Alex Brainman:

Patch Set 1:

Your change LGTM (after my comment addressed).

Alex

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/220578.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: bbe30ba) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/220578 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Richard Wilkes:

Patch Set 2:

Hmm... I'm not sure how to make that happen. I did this:

git commit --amend
git push --force

It shows as having the updated commit message in my fork and the bot seems to have done something, but I don't see the updated message here. What am I supposed to be doing to make this work? I see an edit button on the web page here, right under the comment... perhaps all I needed to do is hit that and update the message?

• Rich

Patch Set 1: Run-TryBot+1

(1 comment)

Thank you very much for working on this.

Alex

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/220578.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Alex Brainman:

Patch Set 2:

Patch Set 2:

Hmm... I'm not sure how to make that happen. I did this:

I don't use Github PRs, so I would not know for sure. But looking at the Wiki page refereed from your PR

https://github.com/golang/go/wiki/GerritBot#how-does-gerritbot-determine-the-final-commit-message

How does GerritBot determine the final commit message?
It uses the title and description of the PR to construct the commit message for the Gerrit Change.

Hopefully it helps.

Alex

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/220578.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Richard Wilkes:

Patch Set 3:

I read that earlier and thought I needed to do a commit -amend to get the desired change. Turns out I was supposed to just edit it in the GitHub UI, which I've now done.

Thanks for the help!

Patch Set 2:

Patch Set 2:

Hmm... I'm not sure how to make that happen. I did this:

I don't use Github PRs, so I would not know for sure. But looking at the Wiki page refereed from your PR

https://github.com/golang/go/wiki/GerritBot#how-does-gerritbot-determine-the-final-commit-message

How does GerritBot determine the final commit message?
It uses the title and description of the PR to construct the commit message for the Gerrit Change.

Hopefully it helps.

Alex

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/220578.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Alex Brainman:

Patch Set 3: Run-TryBot+1

I read that earlier and thought I needed to do a commit -amend to get the desired change. Turns out I was supposed to just edit it in the GitHub UI, which I've now done.

LGTM after try-bots are happy.

Thanks again for the fix.

Alex

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/220578.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gobot Gobot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e3a194bf

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/220578.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR is being closed because golang.org/cl/220578 has been merged.