Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: add -modversion flag setting main module version on debug.ReadBuildInfo #43535

Closed
wants to merge 2 commits into from

Conversation

Fryuni
Copy link

@Fryuni Fryuni commented Jan 6, 2021

As discussed in #29228 currently it is required very hacky workarounds to get the version of the built binary.
From my understanding the most used are variations of 'go build -ldflags="-X main.version=${version}"' and reading from the injected variable.

Currently building a binary using "go build" has a hardcoded "(devel)" version for the main module on the data for ReadBuildInfo. The program has to be installed from "go get" or "go install" in order for the version to be added.

This PR adds a "-modversion" to set the value for the main module version.

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jan 6, 2021
@gopherbot
Copy link

This PR (HEAD: 160c3da) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/281912 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/281912.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 1ba020b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/281912 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Daniel Martí:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/281912.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Jay Conrod:

Patch Set 2: Code-Review-1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/281912.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Luiz Ferraz:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/281912.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Daniel Martí:

Patch Set 2: Code-Review-2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/281912.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Luiz Augusto Ferraz:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/281912.
After addressing review feedback, remember to publish your drafts!

@Fryuni Fryuni closed this Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants