-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Closed
Description
What version of Go are you using (go version)?
1.17rc1
What operating system and processor architecture are you using (go env)?
GopherJS with Go 1.17
What did you do?
64d323f improves the performance of the hash/maphash package, but in doing so makes the package even "less" safe than it was before. In 1.16 this was worked around in GopherJS (where pointer arithmetic is not possible) with gopherjs/gopherjs@ccebfda. The recent changes will require a much larger delta, as now every caller to rthash will need to be updated, to use calling semantics more similar to the 1.16 version.
What did you expect hope to see?
A purego implementation of hash/maphash would solve this problem. And perhaps it would be useful in other scenarios as well?
nevkontakte, DeedleFake, ainar-g and Dr-Terrible