regexp: add comment in example test describing tricky behavior #56973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR (HEAD: 1e7b236) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/453877 to see it. Tip: You can toggle comments from me using the |
gopherbot
pushed a commit
to golang/oscar
that referenced
this pull request
Oct 6, 2025
text-embedding-004 is deprecated and will stop working in January 2026, so switch to gemini-embedding-001. The results are better in some ways and worse in others. They should work about the same for the related issues feature, although we may want to adjust the thresholds after a few days of seeing how the new embeddings do for real usage. Before: > regexp issue about adding iterators ^D 0.67100 golang/go#61902 # proposal: regexp: add iterator forms of matching methods 0.67000 golang/go#351 # Regexp can't handle lazy quantifiers 0.66900 golang/go#43332 # regexp: Repeated capture groups only capturing final captured match. 0.66300 golang/go#64108 # regexp: Documentation doesn't mention that (?<name>...) capturing group syntax isn't currently supported 0.65500 golang/go#56507 # regexp: improve Regexp.ReplaceAll documentation and tests related to Expand part > proposal: regexp: add iterator forms of matching methods ^D 0.75600 golang/go#61902 # proposal: regexp: add iterator forms of matching methods 0.67000 golang/go#21463 # proposal: regexp: Optimize fixed-length patterns 0.66700 golang/go#54047 # proposal: Go 2: add a new iterator syntax, package, interfaces 0.66100 golang/go#43557 # proposal: Go 2: function values as iterators 0.65500 golang/go#65742 # proposal: Go 2: range-over-function + range over types implementing iterator interface > We propose to add methods to regexp that allow iterating over matches instead of having to accumulate all the matches into a slice. This is one of a collection of proposals updating the standard library for the new 'range over function' feature (#61405). It would only be accepted if that proposal is accepted. See golang/oscar#61897 for a list of related proposals. Regexp has a lot of methods that return slices of all matches (the “FindAll*” methods). Each should have an iterator equivalent that doesn’t build the slice. They can be named by removing the “Find” prefix. The docs would change as follows. (Plain text is unchanged; strikethrough is removed, bold is added): ^D 0.86400 golang/go#61902 # proposal: regexp: add iterator forms of matching methods 0.71700 https://go.dev/wiki/RangefuncExperiment#can-you-provide-more-motivation-for-range-over-functions # Go Wiki: Rangefunc Experiment > Can you provide more motivation for range over functions? 0.69100 golang/go#61901 # bytes, strings: add iterator forms of existing functions 0.68800 golang/go#61899 # slices: add iterator-related functions 0.68200 https://go.dev/pkg/regexp/?m=old#Regexp.FindAll # Package regexp > type Regexp > func (*Regexp) FindAll After: > regexp issue about adding iterators ^D 0.76400 golang/go#50650 # regexp: add the missing is 0.71900 golang/go#17146 # How about add MatchStrings() in regexp meet match string more than one? 0.71200 golang/go#56973 # regexp: add comment in example test describing tricky behavior 0.69700 golang/go#61902 # proposal: regexp: add iterator forms of matching methods 0.69500 golang/go#63350 # regexp/syntax: use min func > proposal: regexp: add iterator forms of matching methods ^D 0.87400 golang/go#61902 # proposal: regexp: add iterator forms of matching methods 0.77400 golang/go#61901 # bytes, strings: add iterator forms of existing functions 0.76400 golang/go#24208 # proposal: regexp: Add functions to the Regexp type to ease accessing named capture groups 0.76300 golang/go#32881 # regexp: Named captures should appear in a hashmap 0.76000 golang/go#66631 # proposal: reflect: Add Type.Fields() iter.Seq[StructField] and Type.Methods() iter.Seq[Method] > We propose to add methods to regexp that allow iterating over matches instead of having to accumulate all the matches into a slice. This is one of a collection of proposals updating the standard library for the new 'range over function' feature (#61405). It would only be accepted if that proposal is accepted. See golang/oscar#61897 for a list of related proposals. Regexp has a lot of methods that return slices of all matches (the “FindAll*” methods). Each should have an iterator equivalent that doesn’t build the slice. They can be named by removing the “Find” prefix. The docs would change as follows. (Plain text is unchanged; strikethrough is removed, bold is added): ^D 0.94900 golang/go#61902 # proposal: regexp: add iterator forms of matching methods 0.86200 golang/go#61901 # bytes, strings: add iterator forms of existing functions 0.83600 golang/go#61899 # slices: add iterator-related functions 0.83100 golang/go#61897 # iter: new package for iterators 0.81100 golang/go#62113 # proposal: x/net/html: add Node.All(), Node.ChildNodes(), Nodes.Parents() iterators Change-Id: Ic6ce353588b62ba7bae12562378b012d18e5feb2 Reviewed-on: https://go-review.googlesource.com/c/oscar/+/708880 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not obvious why this example leads to its output and a comment
may help.