Permalink
Commits on Nov 14, 2016
  1. Flag error strings that end with a newline

    Signed-off-by: Joe Tsai <joetsai@google.com>
    dominikh committed with dsnet Nov 14, 2016
Commits on Oct 13, 2016
Commits on Oct 4, 2016
  1. Add ACL as a common initialism.

    Signed-off-by: Joe Tsai <joetsai@google.com>
    froodian committed with dsnet Oct 4, 2016
  2. Remove check for 0-length make.

    While a 0-length make is sometimes done when a user should
    have used "var s []int", the current lint check is reported to
    cause too many false positives on legitimate uses of 0-length make.
    This occurs because there is a semantic difference between
    "make([]int, 0)" and "var s []int".
    
    Fixes #234
    dsnet committed Oct 4, 2016
Commits on Oct 3, 2016
  1. Remove me from list of bad receivers.

    Signed-off-by: Joe Tsai <joetsai@google.com>
    twpayne committed with dsnet Oct 3, 2016
  2. Configure Travis to use Go1.7.

    dsnet committed Oct 3, 2016
  3. Drop support for Go 1.5.

    Signed-off-by: Joe Tsai <joetsai@google.com>
    alandonovan committed with dsnet Sep 16, 2016
Commits on Oct 1, 2016
  1. Disallow basic types as keys in context.WithValue().

    Signed-off-by: Joe Tsai <joetsai@google.com>
    mdlayher committed with dsnet Oct 1, 2016
  2. Avoid type-inference warnings due to partial type info.

    Signed-off-by: Joe Tsai <joetsai@google.com>
    alandonovan committed with dsnet Sep 15, 2016
  3. Fix crash on ill-formed receiver type.

    Signed-off-by: Joe Tsai <joetsai@google.com>
    alandonovan committed with dsnet Sep 7, 2016
Commits on Apr 28, 2016
Commits on Apr 26, 2016
Commits on Apr 5, 2016
  1. Update golint's copy of the part of cmd/go required for matching pack…

    …age patterns like "std".
    dsymonds committed Apr 5, 2016
Commits on Mar 17, 2016
  1. Split (importer).ImportFrom into its own build-tag-guarded file.

    This keeps the lint package building with Go 1.5.
    dsymonds committed Mar 17, 2016
  2. Switch to the go/types API in the standard library.

    This means that golint now requires Go 1.5 or later.
    It also means that vendored packages will now be correctly handled,
    assuming you are using Go 1.6 or later.
    
    Fixes #151.
    dsymonds committed Mar 17, 2016
Commits on Oct 18, 2015
  1. Fix lint check for ValueSpec docs.

    For standalone package-global var/consts, there is still a GenDecl
    with no parens, and the var/const's doc comment may be attached to
    that instead of to the ValueSpec.
    
    Fixes #166.
    dsymonds committed Oct 18, 2015
Commits on Oct 5, 2015
  1. Fix a typo: lineMake -> lintMake

    Signed-off-by: David Symonds <dsymonds@golang.org>
    plenluno committed with dsymonds Oct 3, 2015
Commits on Jun 25, 2015
  1. Lint files that use cgo.

    go/build separates Go files into two categories (not counting test
    files): pure Go files (GoFiles), and files that use cgo (CgoFiles).
    
    Signed-off-by: David Symonds <dsymonds@golang.org>
    dominikh committed with dsymonds Jun 23, 2015
Commits on Jun 23, 2015
  1. Revert "Add unitless duration lint check."

    This reverts commit b550591.
    
    It turned out to have too many false positives.
    dsymonds committed Jun 23, 2015
Commits on Jun 22, 2015
  1. Add unitless duration lint check.

    Fixes #130.
    
    Signed-off-by: David Symonds <dsymonds@golang.org>
    josharian committed with dsymonds Jun 16, 2015
  2. Avoid panicking on a method-less receiver.

    This is malformed Go code that go/parser accepts;
    handle the situation gracefully.
    
    Fixes #134.
    dsymonds committed Jun 19, 2015
Commits on Jun 18, 2015
  1. Expand suggestions to cope with sub-line replacements.

    This changes the Errorf check to provide a suggestion.
    dsymonds committed Jun 2, 2015
Commits on Jun 16, 2015
  1. Fix link to CodeReviewComments wiki page.

    Fixes #131.
    
    Signed-off-by: David Symonds <dsymonds@golang.org>
    nikai3d committed with dsymonds Jun 16, 2015
Commits on Jun 13, 2015
Commits on Jun 2, 2015
  1. Implement suggested replacements for problems.

    This adds the infrastructure for plumbing suggestions through,
    and implements a suggested fix for range-loop.
    dsymonds committed Jun 2, 2015
Commits on May 19, 2015
  1. Add links to style guides.

    Fixes #125.
    
    Signed-off-by: David Symonds <dsymonds@golang.org>
    pconerly committed with dsymonds May 19, 2015
Commits on Apr 15, 2015
  1. Emacs package: Quote command arguments.

    This allows using the Emacs package with file names containing shell
    metacharacters.
    
    Fixes #83
    
    Signed-off-by: David Symonds <dsymonds@golang.org>
    phst committed with dsymonds Apr 13, 2015
Commits on Apr 8, 2015
  1. Check for `t.Error(fmt.Sprintf(...))` where t is a *testing.T.

    Suggest replacing it with `t.Errorf(...)`.
    
    Fixes #115.
    
    Signed-off-by: David Symonds <dsymonds@golang.org>
    d4l3k committed with dsymonds Apr 6, 2015
Commits on Mar 22, 2015
  1. Improve Structure and Formatting of README.

    * The installation instructions were too easy to miss (I missed them)
    * It’s a Markdown file but wasn’t using Markdown markup.
    
    Fixes #113.
    
    Signed-off-by: David Symonds <dsymonds@golang.org>
    Avi Flax committed with dsymonds Mar 20, 2015
Commits on Mar 19, 2015
  1. Avoid suggesting omitting the LHS type of a var decl for known weaker…

    … types.
    
    This arises when type checking fails, and golint cannot determine
    that the LHS and RHS are truly of different types. In that situation
    it is an annoying false positive.
    dsymonds committed Mar 18, 2015