From 18b1a0c48f48fcc98c44f92a17530656899b0dc5 Mon Sep 17 00:00:00 2001 From: Changkun Ou Date: Tue, 31 Aug 2021 09:09:04 +0200 Subject: [PATCH] cmd/gomobile: use Apple Development over iPhone Developer Apple Development Program was introduced in WWDC2015. It is 2021 today, and there should have no possibility to use iPhone Developer certificate for code signing. This CL replaces "iPhone Developer" by "Apple Development" so that cmd/gomobile can use the correct certificate to sign the building application. Otherwise, gomobile throws an error gomobile: failed to pull the signing certificate to determine your team ID: exit status 44 Updates golang/go#47238 Change-Id: Ia48c03ff7cda39a95159e0f77e7ba7042776f9ef Reviewed-on: https://go-review.googlesource.com/c/mobile/+/346151 Reviewed-by: Hajime Hoshi Reviewed-by: Dmitri Shuralyov Run-TryBot: Hajime Hoshi TryBot-Result: Go Bot Trust: Hajime Hoshi Trust: Dmitri Shuralyov --- bind/objc/seq_test.go | 4 ++-- cmd/gomobile/build_iosapp.go | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/bind/objc/seq_test.go b/bind/objc/seq_test.go index 5452461c0..e6ef5e71d 100644 --- a/bind/objc/seq_test.go +++ b/bind/objc/seq_test.go @@ -604,7 +604,7 @@ const pbxproj = `// !$*UTF8*$! CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE; CLANG_WARN_UNREACHABLE_CODE = YES; CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; - CODE_SIGN_IDENTITY = "iPhone Developer"; + CODE_SIGN_IDENTITY = "Apple Development"; COPY_PHASE_STRIP = NO; DEBUG_INFORMATION_FORMAT = dwarf; ENABLE_STRICT_OBJC_MSGSEND = YES; @@ -662,7 +662,7 @@ const pbxproj = `// !$*UTF8*$! CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE; CLANG_WARN_UNREACHABLE_CODE = YES; CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; - CODE_SIGN_IDENTITY = "iPhone Developer"; + CODE_SIGN_IDENTITY = "Apple Development"; COPY_PHASE_STRIP = NO; DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym"; ENABLE_NS_ASSERTIONS = NO; diff --git a/cmd/gomobile/build_iosapp.go b/cmd/gomobile/build_iosapp.go index 67fe3b596..eeb1d7d7d 100644 --- a/cmd/gomobile/build_iosapp.go +++ b/cmd/gomobile/build_iosapp.go @@ -152,11 +152,11 @@ func goIOSBuild(pkg *packages.Package, bundleID string, archs []string) (map[str } func detectTeamID() (string, error) { - // Grabs the first certificate for "iPhone Developer"; will not work if there + // Grabs the certificate for "Apple Development"; will not work if there // are multiple certificates and the first is not desired. cmd := exec.Command( "security", "find-certificate", - "-c", "iPhone Developer", "-p", + "-c", "Apple Development", "-p", ) pemString, err := cmd.Output() if err != nil { @@ -422,7 +422,7 @@ var projPbxprojTmpl = template.Must(template.New("projPbxproj").Parse(`// !$*UTF CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; CLANG_WARN_UNREACHABLE_CODE = YES; CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; - "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer"; + "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "Apple Development"; COPY_PHASE_STRIP = NO; DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym"; ENABLE_NS_ASSERTIONS = NO; @@ -435,7 +435,7 @@ var projPbxprojTmpl = template.Must(template.New("projPbxproj").Parse(`// !$*UTF GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 8.3; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; MTL_ENABLE_DEBUG_INFO = NO; SDKROOT = iphoneos; TARGETED_DEVICE_FAMILY = "1,2";