This repository was archived by the owner on Jun 27, 2023. It is now read-only.
Test helper in mock #245
Merged
Test helper in mock #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balshetzer
suggested changes
Dec 5, 2018
Collaborator
Author
|
@balshetzer PTAL |
balshetzer
suggested changes
Dec 8, 2018
Collaborator
balshetzer
left a comment
balshetzer
left a comment
There was a problem hiding this comment.
The way the changes were committed makes it so that it seems like there were no changes since the last review. This makes it harder to just take a quick look at the changes.
Collaborator
Author
|
@balshetzer PTAL |
balshetzer
approved these changes
Dec 8, 2018
Controller takes a TestReporter but will convert it to a TestHelper. If the given TestReproter does not implement a TestHelper it will wrap it in a nopTestHelper.
Using T.Helper() better directs the callstack to point at the offending line in the production code. fixes #239
|
can you pease tag this version. When we use |
Collaborator
Author
|
@mikhailkolesnik tagged v1.2.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #239