Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/websocket: add example of (*Server).Handshake #50

Open
wants to merge 1 commit into
base: master
from

Conversation

@tomocy
Copy link

commented Aug 19, 2019

The existing (*Server).Handshake lacks examples of how it is used, so add runnable and testable versions of them

Fixes golang/go#32866

@googlebot googlebot added the cla: yes label Aug 19, 2019
@tomocy tomocy changed the title x/net/websocket: add runnable and testable example of (*Server).Hands… x/net/websocket: add example of (*Server).Handshake Aug 19, 2019
@gopherbot

This comment has been minimized.

Copy link

commented Aug 19, 2019

This PR (HEAD: 136aed7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/190819 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@tomocy tomocy force-pushed the tomocy:add-example-server branch from 136aed7 to 74dc6ea Aug 19, 2019
@gopherbot

This comment has been minimized.

Copy link

commented Aug 19, 2019

This PR (HEAD: 74dc6ea) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/190819 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

The existing (*Server).Handshake lacks examples of how it is used, so add runnable and testable versions of them

Fixes #32866
@tomocy tomocy force-pushed the tomocy:add-example-server branch from 74dc6ea to 45fbd28 Aug 26, 2019
@gopherbot

This comment has been minimized.

Copy link

commented Aug 26, 2019

This PR (HEAD: 45fbd28) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/190819 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

commented Oct 1, 2019

Message from Andrew Bonventre:

Patch Set 4: Run-TryBot+1

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/190819.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Oct 1, 2019

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=3f210d2b


Please don’t reply on this GitHub thread. Visit golang.org/cl/190819.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Oct 1, 2019

Message from Gobot Gobot:

Patch Set 4:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/1820cca7/freebsd-amd64-12_0_222f1b44.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/190819.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Oct 1, 2019

Message from Gobot Gobot:

Patch Set 4: TryBot-Result-1

9 of 10 TryBots failed:
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/1820cca7/freebsd-amd64-12_0_222f1b44.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/1820cca7/windows-amd64-2016_3f265617.log
Failed on linux-amd64 (Go 1.13.x): https://storage.googleapis.com/go-build-log/0c076032/linux-amd64_76365e6e.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/1820cca7/openbsd-amd64-64_1fd14079.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/1820cca7/linux-amd64_784d376c.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/1820cca7/linux-386_7912202a.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/1820cca7/windows-386-2008_4706fff8.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/1820cca7/linux-amd64-race_90180f1c.log
Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/1820cca7/android-amd64-emu_6a8d3e84.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/190819.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Oct 10, 2019

Message from Andrew Bonventre:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/190819.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.