Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: connection pool periodically sends ping frame and closes the #55

Open
wants to merge 4 commits into
base: master
from

Conversation

@caesarxuchao
Copy link

caesarxuchao commented Oct 1, 2019

connection if the ping is not responded on time.

DO NOT SUBMIT

Updates golang/go#31643

Implemented the easiest part of golang/go#31643 (comment).

I'm not sure about how to expose the pingPeriod and pingTimeout configurations. Maybe we can plumb that through the http.Transport?

@bradfitz @lavalamp PTAL. Thanks.

connection if the ping is not responded on time.

DO NOT SUBMIT

Updates golang/go#31643
@googlebot googlebot added the cla: yes label Oct 1, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 1, 2019

This PR (HEAD: bc0d6c6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/198040 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 1, 2019

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 14, 2019

Message from Brad Fitzpatrick:

Patch Set 1:

(11 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 17, 2019

Message from Chao Xu:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 19, 2019

This PR (HEAD: 840ca83) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/198040 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@caesarxuchao caesarxuchao force-pushed the caesarxuchao:ping-connection branch from 840ca83 to b2e6f87 Oct 19, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 19, 2019

This PR (HEAD: b2e6f87) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/198040 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 19, 2019

Message from Chao Xu:

Patch Set 2:

Hi Brad,

Thank you for the review. I modified the periodic ping behavior to start only after the readloop has been idle for a while, and to stop once new frame is received in the readloop.

I have also addressed other comments.

PTAL. Thank you.


Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Oct 19, 2019

Message from Chao Xu:

Patch Set 3:

Patch Set 2:

Hi Brad,

Thank you for the review. I modified the periodic ping behavior to start only after the readloop has been idle for a while, and to stop once new frame is received in the readloop.

I have also addressed other comments.

PTAL. Thank you.

I will be OOO until Oct. 30.


Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 21, 2019

Message from Brad Fitzpatrick:

Patch Set 3:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

The race in golang/go#11513 does not affect
time.AfterFunc, because the timer returned by time.AfterFunc() does not
have the buffered channel at all.
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 22, 2019

This PR (HEAD: 331a10c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/198040 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 22, 2019

Message from Brad Fitzpatrick:

Patch Set 4:

(6 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 22, 2019

Message from Daniel Smith:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 23, 2019

Message from Chao Xu:

Patch Set 4:

(4 comments)

Patch Set 4:

(6 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 23, 2019

This PR (HEAD: 5058c86) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/198040 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.