Skip to content

Conversation

@andyrzhao
Copy link
Contributor

The example test implementation uses stdin, which does not work in all environments:
golang/go#45523

Removing for now to unblock release.

@google-cla google-cla bot added the cla: yes label Apr 12, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: baf4632) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/309469 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 1: Run-TryBot+1 Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/309469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=ffd44109


Please don’t reply on this GitHub thread. Visit golang.org/cl/309469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 1: Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/309469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result+1

SlowBots are happy.

SlowBot builds that ran:

  • android-amd64-emu

Please don’t reply on this GitHub thread. Visit golang.org/cl/309469.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 13, 2021
The example test implementation uses stdin, which does not work in all environments:
golang/go#45523

Removing for now to unblock release.

Change-Id: I49bafa9fe1d973b7c1d7ce00f51f110f9aa4a5a6
GitHub-Last-Rev: baf4632
GitHub-Pull-Request: #488
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/309469
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Trust: Cody Oss <codyoss@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/309469 has been merged.

@gopherbot gopherbot closed this Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants