-
Notifications
You must be signed in to change notification settings - Fork 190
internal/godoc/dochtml: enhance output parsing for example func #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR (HEAD: a2fb103) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/600415. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from 洪偉達: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Alan Donovan: Patch Set 4: Code-Review+1 (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
a2fb103 to
8942109
Compare
|
This PR (HEAD: 8942109) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/600415. Important tips:
|
|
Message from 洪偉達: Patch Set 5: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Robert Findley: Patch Set 5: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Robert Findley: Patch Set 5: Auto-Submit+1 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-07-24T17:13:00Z","revision":"6f4bfe00a98ad244df22c6d22f8e9ec4317e6f23"} Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from kokoro: Patch Set 5: Kokoro presubmit build queued for golang/pkgsite/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from kokoro: Patch Set 5: Kokoro presubmit build starting for golang/pkgsite/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Robert Findley: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from kokoro: Patch Set 5: kokoro-CI-1 Kokoro presubmit build finished with status: FAILURE Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from 洪偉達: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Robert Findley: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Robert Findley: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Robert Findley: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
8942109 to
1eb9099
Compare
|
This PR (HEAD: 1eb9099) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/600415. Important tips:
|
Current logic for detecting "concluding line comment" is not strict enough that it may cause false-positive, causing some normal comment (and code following it) to be discarded in the rendered web page. Ensure that "concluding line comment" can only be prefixed by spaces. Also add corresponding test case. Fixes golang/go#65450 Change-Id: Ibb27edb7a6addbb255e4eeffe9c533862b1c0db1
1eb9099 to
7312ff3
Compare
|
This PR (HEAD: 7312ff3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/600415. Important tips:
|
|
Message from 洪偉達: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Robert Findley: Patch Set 7: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-13T12:33:19Z","revision":"4201077b0dabbebffc37718e1c425074654b63f0"} Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from kokoro: Patch Set 7: Kokoro presubmit build queued for golang/pkgsite/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from kokoro: Patch Set 7: Kokoro presubmit build starting for golang/pkgsite/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Robert Findley: Patch Set 7: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
|
Message from kokoro: Patch Set 7: kokoro-CI+1 Kokoro presubmit build finished with status: SUCCESS Please don’t reply on this GitHub thread. Visit golang.org/cl/600415. |
Current logic for detecting "concluding line comment" is not strict enough that it may cause false-positive, causing some normal comment (and code following it) to be discarded in the rendered web page. Ensure that "concluding line comment" can only be prefixed by spaces. Also add corresponding test case. Fixes golang/go#65450 Change-Id: Ief9ec5326aa94965ca02d3278398cc5663ba395f GitHub-Last-Rev: 7312ff3 GitHub-Pull-Request: #93 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/600415 kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Alan Donovan <adonovan@google.com>
|
This PR is being closed because golang.org/cl/600415 has been merged. |
Current logic for detecting "concluding line comment" is not strict
enough that it may cause false-positive, causing some normal comment
(and code following it) to be discarded in the rendered web page.
Ensure that "concluding line comment" can only be prefixed by spaces.
Also add corresponding test case.
Fixes golang/go#65450