Skip to content

internal/godoc/dochtml: enhance output parsing for example func #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

internal/godoc/dochtml: enhance output parsing for example func #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions internal/godoc/dochtml/internal/render/linkify_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,18 @@ b := 1
line comment.
*/
</pre>
`,
},
{
"An Output comment must appear at the start of the line.",
`_ = true
// This comment containing "// Output:" is not treated specially.
`,
`
<pre class="Documentation-exampleCode">
_ = true
// This comment containing &#34;// Output:&#34; is not treated specially.
</pre>
`,
},
} {
Expand Down
3 changes: 2 additions & 1 deletion internal/godoc/dochtml/internal/render/render.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ import (

var (
// Regexp for example outputs.
exampleOutputRx = regexp.MustCompile(`(?i)//[[:space:]]*(unordered )?output:`)
// Keep consistent with outputPrefix in GOROOT/src/go/doc/example.go.
exampleOutputRx = regexp.MustCompile(`(?i)^[[:space:]]*//[[:space:]]*(unordered )?output:`)
)

type Renderer struct {
Expand Down