Permalink
Commits on Jan 9, 2019
  1. protoc-gen-go: fix oneof name mangling regression (#782)

    dsnet committed Jan 9, 2019
    The generator currently uses an unintuitive and stateful algorithm
    for name generation where it "fixes" name conflicts by appending "_"
    to the end of the new name.
    
    PR#657 refactored the generator code and noticed that the above
    algorithm was not properly taking into account that a Get method is
    generated for parent oneofs, fixing it in the same PR. While this is
    more correct, this breaks users (see #780) since it means that the
    generation of names can change.
    
    This PR changes the name mangling logic to be as it was previously.
    This does mean that some new proto files may be unbuildable,
    but that is arguably better than breaking existing proto files.
    
    Fixes #780