Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv2: encoding/protojson: more specific resolver errors #1008

Closed
dsnet opened this issue Jan 6, 2020 · 2 comments
Closed

APIv2: encoding/protojson: more specific resolver errors #1008

dsnet opened this issue Jan 6, 2020 · 2 comments
Labels

Comments

@dsnet
Copy link
Member

@dsnet dsnet commented Jan 6, 2020

In the case where the resolver could not resolve an extension or Any message, it returns a protoregistry.NotFound error. This is unhelpful to users. We should have it specifically say which message or extension could not be resolved.

Same for prototext.

@dsnet dsnet added the blocks-v2 label Jan 6, 2020
@cybrcodr

This comment has been minimized.

Copy link
Contributor

@cybrcodr cybrcodr commented Jan 7, 2020

I just peruse the codebase and I think this only happens in ...
https://go.googlesource.com/protobuf/+/refs/heads/master/encoding/prototext/encode.go#346

which should be fixed in https://golang.org/cl/204602

@cybrcodr

This comment has been minimized.

Copy link
Contributor

@cybrcodr cybrcodr commented Jan 7, 2020

My bad, the link I showed in previous posting does not actually use the error text. So yeah, V2 codebase does not return such error as far as I know of. Closing this out.

@cybrcodr cybrcodr closed this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.