Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv2: track breaking changes #867

Open
dsnet opened this issue Jun 11, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@dsnet
Copy link
Member

commented Jun 11, 2019

This is a meta-issue for tracking any breaking changes that occur before the final v2 release. Since v2 is not yet released, we reserve the right to make breaking changes to improve the API to be as good as it can be.

The CL (changelist) that introduces a breaking change will be posted here as a comment. Subscribe to this issue to be notified of breakages. We try to batch multiple breaking changes close together in time to reduce user churn.

@robbertvanginkel

This comment has been minimized.

Copy link

commented Jun 12, 2019

Is there any rough idea of when api-v2 will become stable/available/recommended?

@dsnet

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

We're aspirationally aiming for GopherCon 2019, which would be the end of July. However, this is aspirational. If the v2 work is not where we would like it to be (i.e., incomplete, buggy, etc...), then we will delay. We estimate that the amount of work left is on the order of months, not years.

@dsnet

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2019

Breaking changes:

  • CL/182537: reflect/protoregistry: remove Files.RangeFilesByPath method
  • CL/175987: reflect/protoreflect: remove bool output for Descriptor.Parent method
  • CL/176942: reflect/protoreflect: remove FieldDescriptor.{Oneof,Extendee} methods
  • CL/174938: reflect/protoreflect: remove {Enum,Message}.Type methods
  • CL/182597: reflect/protoreflect: remove KnownFields and UnknownFields interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.