Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: inline the implementation of protoimpl.X.ExtensionDescFromType #1056

Merged
merged 1 commit into from Mar 13, 2020

Conversation

@dsnet
Copy link
Member

dsnet commented Mar 13, 2020

No description provided.

@dsnet

This comment has been minimized.

Copy link
Member Author

dsnet commented Mar 13, 2020

Technically, this differs from before in that it doesn't assign a nil *ExtensionDesc if the assertion fails. I don't know how much this matters.

@neild
neild approved these changes Mar 13, 2020
@dsnet dsnet merged commit b860323 into api-v1 Mar 13, 2020
3 checks passed
3 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dsnet dsnet deleted the ext-desc branch Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.