Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: use google.golang.org/protobuf/testing/protopack for tests #1063

Merged
merged 1 commit into from Mar 20, 2020
Merged

Conversation

@dsnet
Copy link
Member

dsnet commented Mar 20, 2020

Use protopack for tests instead of hard-coded binary data.

@dsnet dsnet requested a review from neild Mar 20, 2020
@dsnet

This comment has been minimized.

Copy link
Member Author

dsnet commented Mar 20, 2020

Tests fail because of #1061

@dsnet dsnet changed the title all: use testing/protopack for tests all: use google.golang.org/protobuf/testing/protopack for tests Mar 20, 2020
@neild
neild approved these changes Mar 20, 2020
Use protopack for tests instead of hard-coded binary data.
@dsnet dsnet force-pushed the protopack branch from 2f1a6df to 67fc6dc Mar 20, 2020
@dsnet dsnet merged commit 3a3cefd into api-v1 Mar 20, 2020
3 checks passed
3 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dsnet dsnet deleted the protopack branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.