Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: convert integer to rune before converting to string #1210

Merged
merged 1 commit into from Sep 24, 2020
Merged

proto: convert integer to rune before converting to string #1210

merged 1 commit into from Sep 24, 2020

Conversation

Saser
Copy link
Contributor

@Saser Saser commented Sep 24, 2020

Go 1.15 introduced a new go vet warning (https://golang.org/doc/go1.15#vet) for conversions of the form string(x) where x is an integer type other than rune or byte. This warning is enabled by default when running go test. As a consequence, running go test github.com/golang/protobuf/proto results in a build failure prior to this commit.

Fixes #1209.

@googlebot
Copy link
Collaborator

googlebot commented Sep 24, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Collaborator

googlebot commented Sep 24, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dsnet
Copy link
Member

dsnet commented Sep 24, 2020

We consider development of the github.com/golang/protobuf module frozen at this point. However, it is an important goal that the module continues to work with higher versions of Go. Therefore, this change is justified.

The PR looks good to me, but will require the CLA to be signed in order to be merged.

Go 1.15 introduced a new `go vet` warning
(https://golang.org/doc/go1.15#vet) for conversions of the form
`string(x)` where `x` is an integer type other than `rune` or `byte`.
This warning is enabled by default when running `go test`. As a
consequence, running `go test github.com/golang/protobuf/proto`
results in a build failure prior to this commit.
@googlebot
Copy link
Collaborator

googlebot commented Sep 24, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Collaborator

googlebot commented Sep 24, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@dsnet dsnet merged commit 3860b27 into golang:master Sep 24, 2020
2 checks passed
@Saser
Copy link
Contributor Author

Saser commented Sep 24, 2020

Thank you for merging and for the very quick response time! :)

This was referenced Mar 12, 2021
This was referenced Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants