Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: rely on protodesc.ToFileDescriptorProto #1214

Merged
merged 1 commit into from Mar 3, 2021
Merged

all: rely on protodesc.ToFileDescriptorProto #1214

merged 1 commit into from Mar 3, 2021

Conversation

dsnet
Copy link
Member

@dsnet dsnet commented Oct 6, 2020

Use protodesc.ToFileDescriptorProto to retrieve the raw descriptors
for legacy support instead of the undocumented ProtoLegacyRawDesc method
that we expect the newer module to provide.

This change will cause the legacy proto package to incur a dependency
on the descriptorpb package.

Use protodesc.ToFileDescriptorProto to retrieve the raw descriptors
for legacy support instead of the undocumented ProtoLegacyRawDesc method
that we expect v2 to provide.

This change will cause the legacy proto package to incur a dependency
on the descriptorpb package.
@dsnet dsnet requested a review from neild Oct 9, 2020
neild
neild approved these changes Oct 22, 2020
@dsnet dsnet merged commit acacf81 into master Mar 3, 2021
3 checks passed
@dsnet dsnet deleted the filedesc branch Mar 3, 2021
This was referenced Mar 18, 2021
This was referenced Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants