Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonpb: Fix marshaling of Duration #1221

Merged
merged 1 commit into from Oct 15, 2020
Merged

Conversation

cybrcodr
Copy link
Contributor

Negative nanosecond should not have negative sign after decimal point.
Add check for max and min seconds.

Fixes #1219.

Negative nanosecond should not have negative sign after decimal point.
Add check for max and min seconds.

Fixes golang#1219.
@cybrcodr cybrcodr requested a review from dsnet October 13, 2020 08:14
@AlekSi
Copy link

AlekSi commented Oct 13, 2020

Please tag 1.4.3 once it is merged 🥺

dsnet
dsnet approved these changes Oct 15, 2020
@cybrcodr cybrcodr merged commit 4846b58 into golang:master Oct 15, 2020
2 checks passed
This was referenced Mar 12, 2021
This was referenced Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsonpb: unexpected output for small negative google.protobuf.Duration (again)
4 participants