Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonpb: bring back old behaviour of handling nulls and JSONPBUnmarshaler #1300

Merged
merged 2 commits into from Mar 24, 2021

Conversation

krzysztofdrys
Copy link
Contributor

Change how jsonpb.Unmarshal handles nested JSONPBMarshaler fields a null json values.

When json null is encountered for a field which implements JSONPBUnmarshaler, jsonpb will now calli unmarshal method from the field, instead of just assigning nil to this field.

Change how jsonpb.Unmarshal handles nested JSONPBMarshaler fields a null json values.

When json null is encountered for a field which implements JSONPBUnmarshaler, jsonpb will now calli unmarshal method from the field, instead of just assigning nil to this field.
jsonpb/decode.go Outdated Show resolved Hide resolved
jsonpb/decode.go Outdated Show resolved Hide resolved
@krzysztofdrys
Copy link
Contributor Author

Thanks for the review @dsnet! I think I have adjusted my PR according to your comments.

@dsnet dsnet merged commit af94003 into golang:master Mar 24, 2021
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants