New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove raw interface #482

Merged
merged 1 commit into from Jan 12, 2018

Conversation

Projects
None yet
2 participants
@dsnet
Member

dsnet commented Jan 11, 2018

There is an internal type to Google called RawMessage that is similar
to json.RawMessage. Since there is no proper proto reflection API,
we special-cased the Bytes method of RawMessage to access the raw bytes.
This is a gross hack since Bytes() []byte is such a common method signature.

Remove this hack.

Fixes #311

Remove raw interface
There is an internal type to Google called RawMessage that is similar
to json.RawMessage. Since there is no proper proto reflection API,
we special-cased the Bytes method of RawMessage to access the raw bytes.
This is a gross hack since Bytes() []byte is such a common method signature.

Remove this hack.

Fixes #311

@dsnet dsnet requested a review from neild Jan 11, 2018

@dsnet

This comment has been minimized.

Show comment
Hide comment
@dsnet
Member

dsnet commented Jan 11, 2018

\cc @tamird

@neild

neild approved these changes Jan 11, 2018

@dsnet dsnet merged commit 7d76aa1 into dev Jan 12, 2018

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dsnet dsnet deleted the nuke-raw branch Jan 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment