README.md, proto: Replaced usage of group in example #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnet
reviewed
Aug 4, 2018
README.md
Outdated
| repeated int64 reps = 3; | ||
| optional group OptionalGroup = 4 { | ||
| required string RequiredField = 5; | ||
| message OptionalNest { |
Member
There was a problem hiding this comment.
This is not valid proto syntax. You can't inline a message like this.
I would just remove the entire reference to groups.
Contributor
Author
There was a problem hiding this comment.
You're right, made a dumb typo there. Will just remove the entire reference.
dsnet
approved these changes
Aug 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #564