Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: document how to build a specific version of `protoc-gen-go` #764

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
2 participants
@jjlin
Copy link
Contributor

commented Nov 28, 2018

If your code is locked to a specific version of github.com/golang/protobuf (e.g., 1.2.0), the default suggestion of go get -u github.com/golang/protobuf/protoc-gen-go may end up building and installing an incompatible version of protoc-gen-go (e.g., as introduced by https://github.com/golang/protobuf/blame/8d0c54c1/proto/proto3_proto/proto3.pb.go#L23).

Provides a workaround for #738.

Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md
Show resolved Hide resolved README.md Outdated
@jjlin

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2018

The last build apparently failed for transient network reasons; closed/reopened to retrigger.

@dsnet

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

Heh, funny trick closing/opening issue to re-trigger Travis.

@dsnet

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

Thank you for the PR.

@dsnet dsnet merged commit 1d3f30b into golang:master Nov 28, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

lfittl added a commit to pganalyze/collector that referenced this pull request Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.