Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cleanly construct a Timestamp #797

merged 1 commit into from Feb 5, 2019


None yet
2 participants
Copy link

commented Feb 5, 2019

The existing code is much more complex.

More cleanly construct a Timestamp
The existing code is much more complex.

@neild neild self-requested a review Feb 5, 2019


neild approved these changes Feb 5, 2019

@neild neild merged commit c823c79 into golang:master Feb 5, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed

@taralx taralx deleted the taralx:patch-2 branch Feb 5, 2019

dsnet added a commit that referenced this pull request Mar 11, 2019

all: update to latest in b5d812f
This merges in the following upstream PRs:
* #797: ptypes: More cleanly construct a Timestamp
* #796: ptypes: Avoid assuming time.Duration is nanoseconds
* #805: proto: remove test dependency on experimental packages
* #808: Delete the conformance test

Change-Id: I104189682bbc0a18e3d8460e57f9fcb45f1f4a46
Reviewed-by: Herbie Ong <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.