Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-go/grpc: inline errUnimplemented function #818

Merged
merged 1 commit into from Mar 16, 2019
Merged

Conversation

dsnet
Copy link
Member

@dsnet dsnet commented Mar 16, 2019

Avoid using an errUnimplemented function, which requires us to
give a name to it, causing possible conflicts.
Instead, just inline it's functionality.

Fixes #817

Avoid using an errUnimplemented function, which requires us to
give a name to it, causing possible conflicts.
Instead, just inline it's functionality.
@dsnet dsnet requested a review from cybrcodr March 16, 2019 00:00
@dsnet dsnet merged commit b85cd75 into master Mar 16, 2019
@dsnet dsnet deleted the fix-grpc branch March 16, 2019 01:51
@solodynamo
Copy link

For folks using this repo using go get, their go builds will fail as It would throw errors like imported "google.golang.org/grpc/codes but not used. Its because their .proto files services defination not uses error codes. To fix use the older release of this repo ie. 1.3.1 by compiling using source instead of go get.
In case of docker :
RUN mkdir -p ${GOPATH}/src/github.com/golang/protobuf && \ curl -sSL https://github.com/golang/protobuf/archive/v${PROTOC_GEN_GO_VER}.tar.gz | tar -xz --strip 1 -C ${GOPATH}/src/github.com/golang/protobuf &&\ cd ${GOPATH}/src/github.com/golang/protobuf && \ go build -ldflags '-w -s' -o /golang-protobuf-out/protoc-gen-go ./protoc-gen-go && \ install -Ds /golang-protobuf-out/protoc-gen-go ${OUTDIR}/usr/bin/
where PROTOC_GEN_GO_VER = 1.3.1

@golang golang locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

errUnimplemented redeclared in this block
3 participants