Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-go/grpc: use status and code packages only if needed #820

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
2 participants
@dsnet
Copy link
Member

commented Mar 18, 2019

In the rare event that a proto file only has a service declaration with
no declared methods, it will not depend on status and code.
Make sure these are not imported in such cases.

protoc-gen-go/grpc: use status and code packages only if needed
In the rare event that a proto file only has a service declaration with
no declared methods, it will not depend on status and code.
Make sure these are not imported in such cases.

@dsnet dsnet requested a review from neild Mar 18, 2019

@neild

neild approved these changes Mar 18, 2019

@neild neild merged commit d3c38a4 into master Mar 18, 2019

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dsnet dsnet deleted the fix-grpc2 branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.