Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonpb: fix marshaling of Duration #885

Merged
merged 1 commit into from Jul 1, 2019

Conversation

Projects
None yet
3 participants
@cybrcodr
Copy link
Contributor

commented Jun 28, 2019

Fix output for negative nanoseconds with zero second.
Add validation on min/max seconds.

Fixes #883

jsonpb: fix marshaling of Duration
Fix output for negative nanoseconds with zero second.
Add validation on min/max seconds.

@cybrcodr cybrcodr requested a review from dsnet Jun 29, 2019

@AlekSi

AlekSi approved these changes Jul 1, 2019

@dsnet

dsnet approved these changes Jul 1, 2019

@cybrcodr cybrcodr merged commit 6c65a55 into master Jul 1, 2019

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dsnet dsnet deleted the jsonpb branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.