From 3fca6a08d78fa36fb3aefda4bfc6e6ed869558d2 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Wed, 8 Dec 2021 10:41:54 -0500 Subject: [PATCH] cmd/gorename: log 'go build' output on failure For golang/go#50043 Change-Id: I90d1e85c59d6f9c9ad30edf0180cb876c2564534 Reviewed-on: https://go-review.googlesource.com/c/tools/+/370254 Trust: Bryan Mills Run-TryBot: Bryan Mills Reviewed-by: Hyang-Ah Hana Kim gopls-CI: kokoro TryBot-Result: Gopher Robot --- cmd/gorename/gorename_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/gorename/gorename_test.go b/cmd/gorename/gorename_test.go index 292805193ee..30b87967140 100644 --- a/cmd/gorename/gorename_test.go +++ b/cmd/gorename/gorename_test.go @@ -331,8 +331,8 @@ func buildGorename(t *testing.T) (tmp, bin string, cleanup func()) { bin += ".exe" } cmd := exec.Command("go", "build", "-o", bin) - if err := cmd.Run(); err != nil { - t.Fatalf("Building gorename: %v", err) + if out, err := cmd.CombinedOutput(); err != nil { + t.Fatalf("Building gorename: %v\n%s", err, out) } return tmp, bin, func() { os.RemoveAll(tmp) } }