txtar: use slices.Clone instead of copy by Stavrospanakakis · Pull Request #523 · golang/tools

Stavrospanakakis · 2024-09-17T11:45:14Z

Use slices.Clone instead of copy now that x/tools uses Go >= 1.22.
Resolves an outstanding TODO.

gopherbot · 2024-09-17T11:52:18Z

This PR (HEAD: 0441413) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/613835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-17T11:59:30Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T14:41:37Z

Message from Michael Matloob:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T14:41:38Z

Message from Michael Matloob:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T14:49:18Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-17T14:30:46Z","revision":"d0ec739775136e297f02e67731cec6d798c150a5"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T14:56:31Z

Message from Michael Matloob:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T14:56:31Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T15:03:50Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T15:03:50Z

Message from Michael Matloob:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T15:03:51Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-17T14:53:03Z","revision":"d0ec739775136e297f02e67731cec6d798c150a5"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T15:03:51Z

Message from Michael Matloob:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T15:11:14Z

This PR (HEAD: 468e405) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/613835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-17T15:18:37Z

Message from Stavros Panakakis:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T15:26:32Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T15:26:33Z

Message from Michael Matloob:

Patch Set 4: Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T15:34:14Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-17T15:14:37Z","revision":"caf8b5806ed179fa7e8e12d765763337bbd792b9"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T15:34:15Z

Message from Sam Thanawalla:

Patch Set 4: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T15:48:43Z

Message from Michael Matloob:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T15:48:43Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T15:48:44Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T17:46:56Z

Message from Tim King:

Patch Set 4: Auto-Submit+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T17:54:21Z

Message from Tim King:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T17:54:22Z

Message from Stavros Panakakis:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T17:54:22Z

Message from Tim King:

Patch Set 5: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/613835.
After addressing review feedback, remember to publish your drafts!

Use slices.Clone instead of copy now that x/tools uses Go >= 1.22. Resolves an outstanding TODO. Change-Id: Ia87f18e5e51f35dda5056538b9d0d0699c514ffc GitHub-Last-Rev: 468e405 GitHub-Pull-Request: #523 Reviewed-on: https://go-review.googlesource.com/c/tools/+/613835 Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-by: Sam Thanawalla <samthanawalla@google.com> Reviewed-by: Tim King <taking@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

gopherbot · 2024-09-17T19:47:19Z

This PR is being closed because golang.org/cl/613835 has been merged.

txtar: use slices.Clone instead of copy

0441413

txtar: return the result of slices.Clone

468e405

gopherbot closed this Sep 17, 2024

Stavrospanakakis deleted the use-slices-clone-instead-of-copy branch September 18, 2024 15:45

Conversation

Stavrospanakakis commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

gopherbot commented Sep 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Stavrospanakakis commented Sep 17, 2024 •

edited

Loading