New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goimports: add possibility to ignore custom user's import grouping #68

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@kamilsk
Copy link

kamilsk commented Jan 2, 2019

I propose to make goimports little bit more strict.

For example, an input is

import (
	"context"
	"github.com/pkg/b"
	"github.com/pkg/a"

	"github.com/pkg/y"
	"github.com/pkg/x"
	"github.com/pkg/z"
)

After goimports it looks like

import (
	"context"

	"github.com/pkg/a"
	"github.com/pkg/b"

	"github.com/pkg/x"
	"github.com/pkg/y"
	"github.com/pkg/z"
)

I don't have a possibility to transform it into something like this

import (
	"context"

	"github.com/pkg/a"
	"github.com/pkg/b"
	"github.com/pkg/x"
	"github.com/pkg/y"
	"github.com/pkg/z"
)
@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 2, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no label Jan 2, 2019

@kamilsk

This comment has been minimized.

Copy link

kamilsk commented Jan 2, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 2, 2019

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 2, 2019

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jan 2, 2019

This PR (HEAD: fcc3616) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/156057 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jan 2, 2019

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/156057.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jan 2, 2019

Message from Brad Fitzpatrick:

Patch Set 1: Code-Review-2

Sorry, I don't want to add more options.

The existing configurability is a bit regrettable.

If you want this ungrouping functionality, it could live in a separate tool.


Please don’t reply on this GitHub thread. Visit golang.org/cl/156057.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jan 2, 2019

This PR is being closed because golang.org/cl/156057 has been abandoned.

@gopherbot gopherbot closed this Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment