From df36d6f4bb16d30427d487f1add1a1fc2adfdf61 Mon Sep 17 00:00:00 2001 From: "Hana (Hyang-Ah) Kim" Date: Tue, 6 Jun 2023 13:36:30 -0400 Subject: [PATCH] src/goToolsInformation.ts: update gopls version and unpin golangci-lint golangci-lint is frequently released (more frequently than vscode-go). The community and maintainers group of golangci-lint are sufficiently large, so we expect breakages/security issues involving the tool to be reasonably monitored and handled. Like the alternative linter `staticcheck`, exclude `golangci-lint` from the pinned tools list. Updates golang/vscode-go#2763 Updates golang/vscode-go#2485 Change-Id: If4d74a56a1da8f58575ab26c0325be8a1f3906a1 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/501200 Run-TryBot: Hyang-Ah Hana Kim Reviewed-by: Jamal Carvalho TryBot-Result: kokoro --- src/goToolsInformation.ts | 11 +++++------ tools/allTools.ts.in | 1 - 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/goToolsInformation.ts b/src/goToolsInformation.ts index 2a8eca26e3..1ad44e15f1 100644 --- a/src/goToolsInformation.ts +++ b/src/goToolsInformation.ts @@ -191,8 +191,7 @@ export const allToolsInformation: { [key: string]: Tool } = { modulePath: 'github.com/golangci/golangci-lint', replacedByGopls: false, isImportant: true, - description: 'Linter', - defaultVersion: 'v1.52.2' + description: 'Linter' }, 'revive': { name: 'revive', @@ -211,10 +210,10 @@ export const allToolsInformation: { [key: string]: Tool } = { description: 'Language Server from Google', usePrereleaseInPreviewMode: true, minimumGoVersion: semver.coerce('1.13'), - latestVersion: semver.parse('v0.11.0'), - latestVersionTimestamp: moment('2022-12-13', 'YYYY-MM-DD'), - latestPrereleaseVersion: semver.parse('v0.12.0-pre.1'), - latestPrereleaseVersionTimestamp: moment('2023-04-24', 'YYYY-MM-DD') + latestVersion: semver.parse('v0.12.2'), + latestVersionTimestamp: moment('2023-06-01', 'YYYY-MM-DD'), + latestPrereleaseVersion: semver.parse('v0.12.2'), + latestPrereleaseVersionTimestamp: moment('2023-06-01', 'YYYY-MM-DD') }, 'dlv': { name: 'dlv', diff --git a/tools/allTools.ts.in b/tools/allTools.ts.in index ee64fc0476..0e6fcb9ff7 100644 --- a/tools/allTools.ts.in +++ b/tools/allTools.ts.in @@ -190,7 +190,6 @@ export const allToolsInformation: { [key: string]: Tool } = { replacedByGopls: false, isImportant: true, description: 'Linter', - defaultVersion: 'v1.52.2' }, 'revive': { name: 'revive',