tools: replace use of 'gopkgs' with 'go list all'

[marwan-at-work]

Currently, if you cmd+shift+P and choose Go: Add Import. The list of imported file looks incorrect. For example, packages within the same module do not show up.

To reproduce, go into a module repo such as golang.org/x/tools and open a Go file such as internal/lsp/source/rename.go.

Try to run the Go: Add Import and notice the list does not include most of the packages that you expect within the tools repo. Or even sometimes you get this error:

Could not find packages. Ensure `gopkgs -format {{.Name}};{{.ImportPath}}` runs successfully.

As a solution, I don't think we have to call out into gopkgs anymore as we can just call go list directly to get all importable paths within a directory.

[gopherbot]

Change https://golang.org/cl/240001 mentions this issue: Fix Add Import action by using go list to suggest import paths

[hyangah]

Thanks @marwan-at-work for investigation and offering the fix.

I want to know if I understand the issue right - since I can't reproduce the issue myself yet. Here is the screenshot.

What's the gopkgs version?
The version I am using is

$ go version -m ~/go/bin/gopkgs
/Users/hakim/go/bin/gopkgs: go1.14.3
path github.com/uudashr/gopkgs/v2/cmd/gopkgs
mod github.com/uudashr/gopkgs/v2 v2.1.2 h1:A0+QH6wqNRHORJnxmqfeuBEsK4nYQ7pgcOHhqpqcrpo=
dep github.com/karrick/godirwalk v1.12.0 h1:nkS4xxsjiZMvVlazd0mFyiwD4BR9f3m6LXGhM2TUx3Y=
dep github.com/pkg/errors v0.8.1 h1:iURUrRGxPUNPdy5/HRSm+Yj6okJ6UtLINN0Q9M4+h3I=

[marwan-at-work]

@hyangah

marwansulaiman@Marwans-MBP go-proxy % go version -m `which gopkgs`
/Users/marwansulaiman/go/bin/gopkgs: go1.14.2
	path	github.com/uudashr/gopkgs/v2/cmd/gopkgs
	mod	github.com/uudashr/gopkgs/v2	v2.1.2	h1:A0+QH6wqNRHORJnxmqfeuBEsK4nYQ7pgcOHhqpqcrpo=
	dep	github.com/karrick/godirwalk	v1.12.0	h1:nkS4xxsjiZMvVlazd0mFyiwD4BR9f3m6LXGhM2TUx3Y=
	dep	github.com/pkg/errors	v0.8.1	h1:iURUrRGxPUNPdy5/HRSm+Yj6okJ6UtLINN0Q9M4+h3I=

and here's what i get when trying to run the command:

[hyangah]

@marwan-at-work thanks - interesting.

So, does gopkgs -format '{{.Name}};{{.ImportPath}};{{.Dir}}' -workDir <the directory> give you an error or the result missing x/tools/.. paths? Strange.

Also confirm that you do not have any special settings enabled, and the extension is using the gopkgs which gopkgs returns. (fyi Go: Locate Go Tools command should give the absolute path to each tool binary).

In general, I think switching to go list is a good idea (one less tool to depend on, and staying consistent with go build). But we need to understand the difference between them (performance and correctness wise). cc/ @uudashr

[uudashr]

Hi there, the reason why we create and use gopkgs is because of performance. At back day, there are no modules, so all the dependencies are goes to gopath and the package on gopath are always increasing. And lot of people using vendors which add more packages to scan.

Nowadays after cleanup by go installation, using go list all seems faster, due to the less packages on the gopath to scan.

On my machine there are 393 packages inside gopath and goroot

gopkgs  0.03s user 0.08s system 88% cpu 0.124 total
go list all  0.53s user 0.31s system 195% cpu 0.432 total

go list all still took longer, but seems still acceptable for user to wait.

[gopherbot]

Change https://golang.org/cl/379235 mentions this issue: src: replace use of gopkgs with go list

[marwan-at-work]

I think golang/go#48545 should close out this issue as well? cc: @hyangah

[gopherbot]

Change https://golang.org/cl/379494 mentions this issue: src/goCodeAction.ts,src/goImport.ts: replace listPackages with golist

[gopherbot]

Change https://golang.org/cl/382475 mentions this issue: vscode-go: remove references to gopkgs

[jamalc]

This is finished with CL 382457.

[pavlelee]

go list -f "{{.Name}};{{.ImportPath}}" all is incomplete in go mod, nearly two-thirds less.

go list -f "{{.Name}};{{.ImportPath}}" all
gopkgs -format '{{.Name}};{{.ImportPath}};{{.Dir}}' -workDir ./