Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: enable strict type checking #57

Closed
hyangah opened this issue May 16, 2020 · 14 comments
Closed

build: enable strict type checking #57

hyangah opened this issue May 16, 2020 · 14 comments
Assignees
@jamalc
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
vscode-go/unplanned

Comments

@hyangah
Copy link
Contributor

hyangah commented May 16, 2020

Currently we disabled --strict, --strictNullChecks, and --strictPropertyInitialization.

History: microsoft/vscode-go#2304
This was referenced May 16, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@hyangah
Copy link
Contributor Author

hyangah commented May 17, 2020

note: i sent multiple PRs (as separate branches) in order to export them as separate CLs, each of which can be reasonably sized. :-(

gopherbot pushed a commit that referenced this issue May 19, 2020
@hyangah
strict: fix strict type check errors in src/avlTree.ts
540e707 
Update #57

Change-Id: I44f25a8fc9f76cab5265365b7a1940dcd2f04217

Change-Id: I44f25a8fc9f76cab5265365b7a1940dcd2f04217
GitHub-Last-Rev: 11759f1
GitHub-Pull-Request: #58
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/234259
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@hyangah hyangah added the NeedsFix The path to resolution is known, but the work has not been done. label May 23, 2020
@hyangah hyangah added this to the Backlog milestone Aug 31, 2020
@golang golang deleted a comment from gopherbot Jan 27, 2021
@golang golang deleted a comment from gopherbot Jan 27, 2021
@golang golang deleted a comment from gopherbot Jan 27, 2021
@golang golang deleted a comment from gopherbot Jan 27, 2021
@golang golang deleted a comment from gopherbot Jan 27, 2021
@golang golang deleted a comment from gopherbot Jan 27, 2021
@golang golang deleted a comment from gopherbot Jan 27, 2021
@golang golang deleted a comment from gopherbot Jan 27, 2021
@jamalc
Copy link
Contributor

jamalc commented Apr 11, 2022

I'd like to pick this work back up ahead of any major refactoring. We have just under 500 errors left excluding test files, 600 with test files. What is the story behind abandoning the PRs linked above?

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/400996 mentions this issue: src/util.ts: throw error when getGoVersion fails

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/401615 mentions this issue: vscode-go: create separate tsconfig for builds

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/401617 mentions this issue: src/goTest: fix strict type errors

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/401619 mentions this issue: src/misc: fix strict type errors in util files

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/401618 mentions this issue: src/language: fix strict type errors

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/401620 mentions this issue: src/misc: fix strict type errors in various commands and data providers

gopherbot pushed a commit that referenced this issue Apr 28, 2022
@jamalc
src/util.ts: throw error when getGoVersion fails
27e8258 
In most cases the use of getGoVersion is expected to return a value.
Updating the function to throw an error in the case that a Go
version is not found makes this explicit. For the exceptions where
an explicit binary path is requested we handle the error thrown and
show the existing warnings.

For #57.

Change-Id: Ib80ceec0636134b6694b0080ff19e0295d49d59f
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/400996
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/403055 mentions this issue: src/debugAdapter: fix strict type errors

gopherbot pushed a commit that referenced this issue May 3, 2022
@jamalc
vscode-go: create separate tsconfig for builds
f08030f 
Adding a separate tsconfig for builds will allow us to have strict
type checking rules enabled for editor environments before enforcing
them for builds and tests.

For #57.

Change-Id: I5059e9bbcc87258ad8accd4c476dd9d9d71f0406
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/401615
TryBot-Result: kokoro <noreply+kokoro@google.com>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopherbot pushed a commit that referenced this issue May 3, 2022
@jamalc
src/goTest: fix strict type errors
1f5edd0 
For #57.

Change-Id: I13bae5ae849fae74cabcf7fe2fe88145320d95b8
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/401617
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
gopherbot pushed a commit that referenced this issue May 3, 2022
@jamalc
src/language: fix strict type errors
8d8695b 
For #57.

Change-Id: Iec4ee1a78692b913da6cc9f3ec9413367647da73
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/401618
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
gopherbot pushed a commit that referenced this issue May 3, 2022
@jamalc
src/misc: fix strict type errors in util files
8de5e1f 
For #57.

Change-Id: I79926f9e9a110cfaec69fe5b484faa244a1c3a66
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/401619
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
gopherbot pushed a commit that referenced this issue May 3, 2022
@jamalc
src/misc: fix strict type errors in various commands and data providers
492f2fc 
For #57.

Change-Id: I18d3ea64f3022ee1ca722ace8d03ec8bbd51fe26
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/401620
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopherbot pushed a commit that referenced this issue May 3, 2022
@jamalc
src/debugAdapter: fix strict type errors
398f8dd 
For #57.

Change-Id: Iff105c0ce4b03e61e9fa8a05567fa99f71d1d217
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/403055
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/403775 mentions this issue: vscode-go: add strict typecheck step to CI

gopherbot pushed a commit that referenced this issue May 3, 2022
@jamalc @gopherbot
vscode-go: add strict typecheck step to CI
8abfcaa 
Test files are excluded from strict typechecking. We plan
to fix errors in those files as needed or remove the tests
with the legacy tooling.

For #57.

Change-Id: I84ea8bc1834e2e1ee58c297fed984bb94ec0de52
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/403775
TryBot-Result: kokoro <noreply+kokoro@google.com>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Auto-Submit: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/405075 mentions this issue: test/mocks: fix strict type errors

@jamalc
Copy link
Contributor

jamalc commented May 12, 2022

Only two directories left, test/integration and test/mocks. Strict type checking is enabled in CI for the rest of the files using tsconfig.strict.json.

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/406303 mentions this issue: test: fix type errors

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/406304 mentions this issue: vscode-go: unify tsconfig for build and test

gopherbot pushed a commit that referenced this issue May 18, 2022
@jamalc
test: fix type errors
3b44015 
For #57.

Change-Id: I712d5eb0596695e2d8db7ac7611c7e938cc4f2ce
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/406303
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@golang golang locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jamalc jamalc

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
vscode-go/unplanned
Development

No branches or pull requests
3 participants
@hyangah @gopherbot @jamalc