Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(dep): Add step to commit changes if PR has dependencies label

Merged
merged 1 commit into from Feb 26, 2022

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Oct 14, 2020

This commit is to perform below steps:

  • If PR is having dependencies label, update files in dist as well
  • If PR doesn't have dependencies label, fail the build if there
    is dirty changes.

Assumption:

  • dependabot PR is always having label dependencies
  • I get username and email from commit log, hope that it will not change. No token is required.
  • Verification will be done after this PR is merged only.

@sayboras sayboras changed the title Feature/update dist ci(dep): Add step to commit changes if PR has dependencies label Oct 14, 2020
@sayboras sayboras marked this pull request as ready for review Oct 14, 2020
@sayboras sayboras added the dependencies label Oct 14, 2020
@sayboras sayboras requested review from a team Oct 14, 2020
@sayboras sayboras added hacktoberfest hacktoberfest-accepted labels Oct 14, 2020
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
@SVilgelm
Copy link
Member

SVilgelm commented Dec 29, 2020

lets merge it after v2.4.0 released and then we can test it, I don't see any problems here, if it's not working, then we can revert

@butuzov
Copy link
Member

butuzov commented Sep 27, 2021

@SVilgelm is time to merge (we are currently past due v2.4.0)?

@SVilgelm
Copy link
Member

SVilgelm commented Feb 26, 2022

finally, let's merge it, more than a year when changes are done :)

This commit is to perform below steps:

- If PR is having dependencies label, update files in dist as well
- If PR doesn't have dependencies label, fail the build if there
is dirty changes.

Closes #55

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@SVilgelm SVilgelm merged commit 03e4bef into golangci:master Feb 26, 2022
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants