Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Setup-Go #403

Merged
merged 4 commits into from Feb 24, 2022
Merged

Remove Setup-Go #403

merged 4 commits into from Feb 24, 2022

Conversation

StevenACoffman
Copy link
Contributor

@StevenACoffman StevenACoffman commented Feb 24, 2022

Per discussion in #365, this removes setup-go dep.

Until this PR is landed, we are stuck and unable to upgrade any dependencies, fix any vulns, due to the inability to build the setup-go package.

So now we remove it and then we will need to explicitly install go, like:

    steps:
      - uses: actions/checkout@v2
      - uses: actions/setup-go@v2  # <-- here
      - name: golangci-lint
        uses: golangci/golangci-lint-action@v2

Of course, it will then require us to bump v3, but I imagine there are further documentation changes required so I am not doing that in this PR.

Signed-off-by: Steve Coffman steve@khanacademy.org

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman StevenACoffman requested a review from SVilgelm Feb 24, 2022
Signed-off-by: Steve Coffman <steve@khanacademy.org>
@SVilgelm
Copy link
Member

SVilgelm commented Feb 24, 2022

Thank you very much for this PR, it looks good to me. Just one note: please update all examples in readme, add the go installation step. I need few day for testing.

@kamilsk kamilsk self-requested a review Feb 24, 2022
@kamilsk
Copy link
Contributor

kamilsk commented Feb 24, 2022

great

Copy link
Member

@SVilgelm SVilgelm left a comment

  • add go installation step in all examples in the README.md file
  • remove skip-go-installation option from action.yml and from README.md files
  • Add a note in the readme that v3 requires explicit go installation step

@SVilgelm
Copy link
Member

SVilgelm commented Feb 24, 2022

Here is the PR I use for testing the changes for this action: sv-tools/mongoifc#49
everything works fine so far

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman
Copy link
Contributor Author

StevenACoffman commented Feb 24, 2022

I think I have now corrected the references you mention, but please let me know if additional references to setup-go are present, or if I should make any further edits.

@magnetikonline
Copy link

magnetikonline commented Mar 9, 2022

Thanks for doing this work @StevenACoffman - great to see it finally in the new @v3 action. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants