Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump @actions/cache from 2.0.2 to 2.0.4 #471

Merged
merged 4 commits into from May 16, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 16, 2022

Bumps @actions/cache from 2.0.2 to 2.0.4.

Changelog

Sourced from @​actions/cache's changelog.

2.0.4

  • Update to v2.0.1 of @actions/http-client #1087
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 16, 2022
@dependabot dependabot bot requested a review from a team May 16, 2022
Copy link
Contributor

@kamilsk kamilsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamilsk
Copy link
Contributor

kamilsk commented May 16, 2022

rebase after #470 is needed

@ldez
Copy link
Member

ldez commented May 16, 2022

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 16, 2022

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@ldez
Copy link
Member

ldez commented May 16, 2022

@dependabot recreate

@kamilsk kamilsk self-requested a review May 16, 2022
Bumps [@actions/cache](https://github.com/actions/toolkit/tree/HEAD/packages/cache) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/actions/toolkit/releases)
- [Changelog](https://github.com/actions/toolkit/blob/main/packages/cache/RELEASES.md)
- [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/cache)

---
updated-dependencies:
- dependency-name: "@actions/cache"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/actions/cache-2.0.4 branch from 0895151 to ac9dfd9 Compare May 16, 2022
@ldez
Copy link
Member

ldez commented May 16, 2022

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 16, 2022

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@kamilsk
Copy link
Contributor

kamilsk commented May 16, 2022

looks like "Update dist files" didn't work before

image

https://github.com/golangci/golangci-lint-action/runs/6450678208?check_suite_focus=true

@kamilsk
Copy link
Contributor

kamilsk commented May 16, 2022

maybe it worked on actions/checkout@v2, 03e4bef, but with actions/checkout@v3 it's broken

for example, I use the same approach https://github.com/qase-tms/specs/blob/cf4154d530e06affba173f2c77fe0186861950bd/.github/workflows/readme.yaml#L23-L29 with actions/checkout@v2

@ldez
Copy link
Member

ldez commented May 16, 2022

Checking out the ref
  /usr/bin/git checkout --progress --force refs/remotes/pull/471/merge
  Note: switching to 'refs/remotes/pull/471/merge'.
  
  You are in 'detached HEAD' state. You can look around, make experimental
  changes and commit them, and you can discard any commits you make in this
  state without impacting any branches by switching back to a branch.
  
  If you want to create a new branch to retain commits you create, you may
  do so (now or later) by using -c with the switch command. Example:
  
    git switch -c <new-branch-name>
  
  Or undo this operation with:
  
    git switch -
  
  Turn off this advice by setting config variable advice.detachedHead to false
  
  HEAD is now at 6af41ce Merge ac9dfd9f4e9ae45cf7d71d5a5c85d73b3c8b11fb into 6aefae24f74d2b8b93b007ce4e7b869e98f1c642

@ldez
Copy link
Member

ldez commented May 16, 2022

actions/checkout#719 (comment)

@ldez
Copy link
Member

ldez commented May 16, 2022

Problem fixed by using the following configuration:

 - uses: actions/checkout@v3
      with:
        fetch-depth: 0
        ref: ${{ github.event.pull_request.head.ref }}

@ldez
Copy link
Member

ldez commented May 16, 2022

I think it's a bug or at least a regression of actions/checkout@v3.

Maybe this PR can fix the problem: actions/checkout#712

ldez
ldez approved these changes May 16, 2022
@kamilsk
Copy link
Contributor

kamilsk commented May 16, 2022

there is no build for 8a10b72 long time

@ldez ldez force-pushed the dependabot/npm_and_yarn/actions/cache-2.0.4 branch from 8a10b72 to 62d83b2 Compare May 16, 2022
@ldez ldez merged commit f3c064d into master May 16, 2022
18 checks passed
@ldez ldez deleted the dependabot/npm_and_yarn/actions/cache-2.0.4 branch May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants