Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Caching in Mono Repo #629

merged 1 commit into from Jan 14, 2023

Support Caching in Mono Repo #629

merged 1 commit into from Jan 14, 2023


Copy link

@bbernays bbernays commented Dec 21, 2022

Right now the go.mod is used as the cache key is expected to always be at the root of the repository. This works for most repositories but when users have a mono repo and supply a working-directory the caching keys should use that as the root directory instead

This PR fixes #479

Also wanted to add that we use golangci extensively in in CloudQuery and this would definitely help us avoid hitting timeouts...

@bbernays bbernays force-pushed the master branch 2 times, most recently from 53f5bc5 to 58bce52 Compare December 21, 2022 19:43
Copy link
Contributor Author

@ldez - Is there anything about this PR that is blocking it being merged?

Copy link

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@ldez ldez merged commit 1626f2b into golangci:master Jan 14, 2023
18 checks passed
Copy link

msokk commented Jan 23, 2023

@ldez any plans to tag a new release? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
enhancement New feature or request
None yet

Successfully merging this pull request may close these issues.

Cache Key doesn't work with working-directory
3 participants