From 77a8601aa372eaab3ad2d7fa1dffa71f28005393 Mon Sep 17 00:00:00 2001 From: Ludovic Fernandez Date: Thu, 28 Mar 2024 19:39:06 +0100 Subject: [PATCH] fix: hide useless warning (#4587) --- .golangci.yml | 4 ++++ pkg/commands/linters.go | 7 +++++++ 2 files changed, 11 insertions(+) diff --git a/.golangci.yml b/.golangci.yml index c6190a00a99d..b5488ad81305 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -160,7 +160,11 @@ issues: linters: [staticcheck] text: "SA1019: c.cfg.Run.ShowStats is deprecated: use Output.ShowStats instead." - path: pkg/commands/config.go + linters: [staticcheck] text: "SA1019: cfg.Run.UseDefaultSkipDirs is deprecated: use Issues.UseDefaultExcludeDirs instead." + - path: pkg/commands/linters.go + linters: [staticcheck] + text: "SA1019: c.cfg.Run.UseDefaultSkipDirs is deprecated: use Issues.UseDefaultExcludeDirs instead." # Deprecated linter options. - path: pkg/golinters/errcheck.go diff --git a/pkg/commands/linters.go b/pkg/commands/linters.go index 61ed0f22f27b..e9c155186852 100644 --- a/pkg/commands/linters.go +++ b/pkg/commands/linters.go @@ -59,6 +59,13 @@ func newLintersCommand(logger logutils.Log) *lintersCommand { } func (c *lintersCommand) preRunE(cmd *cobra.Command, _ []string) error { + // Hack to hide deprecation messages related to `--skip-dirs-use-default`: + // Flags are not bound then the default values, defined only through flags, are not applied. + // In this command, linters information are the only requirements, i.e. it don't need flag values. + // + // TODO(ldez) add an option (check deprecation) to `Loader.Load()` but this require a dedicated PR. + c.cfg.Run.UseDefaultSkipDirs = true + loader := config.NewLoader(c.log.Child(logutils.DebugKeyConfigReader), c.viper, cmd.Flags(), c.opts.LoaderOptions, c.cfg) if err := loader.Load(); err != nil {