Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no error detected if the project is a v2 module with the pre-compiled binaries and Go 1.13beta1 #604

Open
pierrre opened this issue Jul 10, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@pierrre
Copy link

commented Jul 10, 2019

golangci-lint version: 1.17.1
Go version: 1.13beta1

I just noticed that no error are detected in my project if:

  • I'm using the pre-build binary
  • my project is using module and is a "v2"
  • Go version is 1.13beta1

It's working if (select one):

  • I'm using the version installed by vscode-go (I guess it's using go get)
  • my project is using module and is a "v1"
  • Go version is 1.12.7

In my "v2 module" projects, my packages import paths contain a "/v2".
That's probably why it's not working anymore.

@pierrre

This comment has been minimized.

Copy link
Author

commented Jul 10, 2019

Currently, my solution is to install golangci-lint with go get.

Sadly I can't use the "go module" syntax to select a stable tag version du to #581 / #595 .
I attempted to fix it in #605 .

So I'm now installing the latest version without Go module support.
GO111MODULE=off go get -u github.com/golangci/golangci-lint/cmd/golangci-lint
The downside is that it's not necessarily a stable version, and the build is not reproducible.

@pierrre pierrre changed the title no error detected if the project is a v2 module with the pre-compiled binaries no error detected if the project is a v2 module with the pre-compiled binaries and Go 1.13beta1 Jul 10, 2019

@pierrre

This comment has been minimized.

Copy link
Author

commented Jul 10, 2019

Actually I have this issue only with Go 1.13beta1, not 1.12.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.