Add linter wastedassign #1651
could you explain why you created a fork of
I see your change:
mode := ssa.BuilderMode(ssa.NaiveForm)
// Some Analyzers may need GlobalDebug, in which case we'll have // to set it globally, but let's wait till we need it. mode := ssa.BuilderMode(0)
It seems, when I read the comment, that a PR on that point on the repo https://github.com/golang/tools will be welcome.
I pay attention to this point because it can impact golangci-lint's performance because this lib is at the heart of golangci-lint's performance optimizations.
I use the mode
OK, I'll create PR on https://github.com/golang/tools
I removed the dependency of wastedassign on sanposhiho/tools, because it seemed to take a while for the proposal to go/tools to be supported.
So, This concern has been addressed now.
Hey, @sanposhiho — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.