Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update staticcheck to v0.1.2 (2020.2.2) #1756

Merged
merged 4 commits into from Feb 21, 2021

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 21, 2021

@ldez ldez added the linter: update version Update version of linter label Feb 21, 2021
@ldez ldez force-pushed the feat/update-static-check branch from ffa93a2 to 1f4dbc1 Compare Feb 21, 2021
@ldez
Copy link
Member Author

ldez commented Feb 21, 2021

run golangci-lint
  Running [/home/runner/golangci-lint-1.37.1-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: directive `//nolint:staticcheck // require changes in github.com/OpenPeeDeeP/depguard` is unused for linter staticcheck (nolintlint)
  Error: directive `//nolint:staticcheck // it's an adapter for golang.org/x/tools/go/packages` is unused for linter staticcheck (nolintlint)
  
  Error: issues found
  Ran golangci-lint in 9552ms

There is an issue because the new version has some rules that cannot be handle by the old version.

@ldez
Copy link
Member Author

ldez commented Feb 21, 2021

I add some exclude-rules to fix the problem

@SVilgelm
Copy link
Member

SVilgelm commented Feb 21, 2021

@ldez please rebase the PR

@ldez ldez force-pushed the feat/update-static-check branch from 4040b48 to 868574a Compare Feb 21, 2021
Copy link
Member

@SVilgelm SVilgelm left a comment

TODO can be removed in next release

@ldez ldez merged commit 2e7c389 into golangci:master Feb 21, 2021
18 checks passed
@ldez ldez deleted the feat/update-static-check branch Feb 21, 2021
This was referenced Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: update version Update version of linter
Projects
None yet
2 participants