Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go-header usage #1785

Merged
merged 1 commit into from Feb 26, 2021
Merged

Fix go-header usage #1785

merged 1 commit into from Feb 26, 2021

Conversation

syndbg
Copy link
Member

@syndbg syndbg commented Feb 26, 2021

There's a known behavior of YAML template blocks using | that they insert a trailing newline.
To remove it add - a.k.a block chomping indicator.

This would address some of the "weird" copyright header linting offenses that happen by following the example golangci-lint config by heart.

pkg/base64/service.go:13:34: Missed string: (goheader)
// limitations under the License.
                                 ^
pkg/hcl/test/testing.go:13:34: Missed string: (goheader)
// limitations under the License.
                                 ^
pkg/ini/service.go:13:34: Missed string: (goheader)
// limitations under the License.
                                 ^

There's a known behavior of YAML template blocks using `|` that they insert a trailing newline.

To remove it add `-` a.k.a block chomping indicator.
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 26, 2021

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@SVilgelm SVilgelm left a comment

Looks good to me. Thank you

@SVilgelm SVilgelm merged commit 89315e0 into golangci:master Feb 26, 2021
18 checks passed
@golangci-automator
Copy link

golangci-automator bot commented Feb 26, 2021

Hey, @syndbg — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@syndbg syndbg deleted the patch-1 branch Feb 26, 2021
This was referenced Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants