Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a version instead of commit id for goconst #1786

Merged
merged 1 commit into from Feb 26, 2021
Merged

Using a version instead of commit id for goconst #1786

merged 1 commit into from Feb 26, 2021

Conversation

SVilgelm
Copy link
Member

@SVilgelm SVilgelm commented Feb 26, 2021

Just an updating a reference in the go, mod file, the version is same.
There was a mistake in the tag names (no v prefix), that was fixed: jgautheron/goconst#16

@SVilgelm SVilgelm requested a review from a team Feb 26, 2021
@SVilgelm SVilgelm added the linter: update version Update version of linter label Feb 26, 2021
ldez
ldez approved these changes Feb 26, 2021
Copy link
Member

@ldez ldez left a comment

LGTM

@SVilgelm SVilgelm merged commit 34e46c7 into master Feb 26, 2021
18 checks passed
@delete-merged-branch delete-merged-branch bot deleted the goconst branch Feb 26, 2021
This was referenced Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the releases should have v prefix
2 participants