Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nilerr linter. #1788

Merged
merged 1 commit into from Feb 26, 2021
Merged

Add nilerr linter. #1788

merged 1 commit into from Feb 26, 2021

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 26, 2021

Finds the code that returns nil even if it checks that the error is not nil.

https://github.com/gostaticanalysis/nilerr

Related to #1787

@ldez ldez added the linter: new Support new linter label Feb 26, 2021
@ldez ldez changed the title Add errnil linter. Add nilerr linter. Feb 26, 2021
@ldez ldez force-pushed the feat/new-linter-errnil branch from 9fdc871 to a977799 Compare Feb 26, 2021
@ldez ldez force-pushed the feat/new-linter-errnil branch from a977799 to 0ae50f7 Compare Feb 26, 2021
Copy link
Member

@SVilgelm SVilgelm left a comment

Looks good to me. Thank you

@ldez ldez merged commit 66fc779 into golangci:master Feb 26, 2021
18 checks passed
@ldez ldez deleted the feat/new-linter-errnil branch Feb 26, 2021
This was referenced Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: new Support new linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants