Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: improve runner to run dir with go.mod #3124

merged 1 commit into from Aug 21, 2022


Copy link

@ldez ldez commented Aug 21, 2022

Related to #3093 and #2969

Currently, we don't have any linter that required this approach, so I cannot add a test.

The test will look like that:

func TestSourcesFromTestdataSubDir(t *testing.T) {
	subDirs := []string{

	for _, dir := range subDirs {
		t.Run(dir, func(t *testing.T) {
			testSourcesFromDir(t, filepath.Join(testdataDir, dir))

@ldez ldez added enhancement New feature or improvement area: tests Continuous integration, tests and other checks labels Aug 21, 2022
Copy link

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@ldez ldez merged commit e1afce4 into golangci:master Aug 21, 2022
16 checks passed
@ldez ldez deleted the feat/runner-improve branch August 21, 2022 14:51
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
area: tests Continuous integration, tests and other checks enhancement New feature or improvement
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants