Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid dependencies #605

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@pierrre
Copy link

commented Jul 10, 2019

Some dependencies have invalid date.

Fixes #581 #595

@CLAassistant

This comment has been minimized.

Copy link

commented Jul 10, 2019

CLA assistant check
All committers have signed the CLA.

@pierrre

This comment has been minimized.

Copy link
Author

commented Jul 10, 2019

I don't know why some vendors have been deleted.

fix invalid dependencies
Some dependencies have invalid date.

Fixes #581 #595

@pierrre pierrre force-pushed the pierrre:bug/fix-581 branch from 3a0bf32 to 6d25b5d Jul 10, 2019

@pierrre

This comment has been minimized.

Copy link
Author

commented Jul 10, 2019

Strangely, the vendored dependencies are not the same if I'm using Go 1.13beta or 1.12.x.
Now they're added correctly.

@pierrre

This comment has been minimized.

Copy link
Author

commented Jul 15, 2019

Is someone available to review this PR ?

@ww-daniel-mora

This comment has been minimized.

Copy link

commented Jul 16, 2019

I am also experiencing this issue

@Helcaraxan

This comment has been minimized.

Copy link

commented Jul 18, 2019

Yes would be great if this could indeed be merged and a 1.17.2 patch release tagged (which would also contain the fix for #612 (i.e. #594).

FWIW. There are 2 other PRs (#583, #614) that address the same issue but I think this is the one that should be merged given it's the only one that actually updates go-critic and only go-critic to a recent commit.

@Helcaraxan Helcaraxan referenced this pull request Jul 18, 2019

Open

fix go mod problem #583

@dajohi
Copy link

left a comment

With this PR, i now get

$ env GOPROXY=direct GO111MODULE=on go build
go: github.com/golangci/errcheck@v0.0.0-20181003203344-ef45e06d44b6: invalid pseudo-version: does not match version-control timestamp (2018-12-23T08:41:20Z)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.